* [KJ][PATCH 03/04]use set_current_state in fs
@ 2007-04-14 8:49 Milind Arun Choudhary
2007-04-14 9:39 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Milind Arun Choudhary @ 2007-04-14 8:49 UTC (permalink / raw)
To: kernel-janitors, nfs; +Cc: linux-kernel, akpm, trond.myklebust
use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs
Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
---
idmap.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
index 9d4a6b2..054ca15 100644
--- a/fs/nfs/idmap.c
+++ b/fs/nfs/idmap.c
@@ -272,7 +272,7 @@ nfs_idmap_id(struct idmap *idmap, struct idmap_hashtable *h,
set_current_state(TASK_UNINTERRUPTIBLE);
mutex_unlock(&idmap->idmap_im_lock);
schedule();
- current->state = TASK_RUNNING;
+ set_current_state(TASK_RUNNING);
remove_wait_queue(&idmap->idmap_wq, &wq);
mutex_lock(&idmap->idmap_im_lock);
@@ -333,7 +333,7 @@ nfs_idmap_name(struct idmap *idmap, struct idmap_hashtable *h,
set_current_state(TASK_UNINTERRUPTIBLE);
mutex_unlock(&idmap->idmap_im_lock);
schedule();
- current->state = TASK_RUNNING;
+ set_current_state(TASK_RUNNING);
remove_wait_queue(&idmap->idmap_wq, &wq);
mutex_lock(&idmap->idmap_im_lock);
--
Milind Arun Choudhary
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [KJ][PATCH 03/04]use set_current_state in fs
2007-04-14 8:49 [KJ][PATCH 03/04]use set_current_state in fs Milind Arun Choudhary
@ 2007-04-14 9:39 ` Eric Dumazet
2007-04-14 10:16 ` Milind Arun Choudhary
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2007-04-14 9:39 UTC (permalink / raw)
To: Milind Arun Choudhary
Cc: kernel-janitors, nfs, linux-kernel, akpm, trond.myklebust
Milind Arun Choudhary a écrit :
> use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs
>
> Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
>
>
> ---
> idmap.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
> index 9d4a6b2..054ca15 100644
> --- a/fs/nfs/idmap.c
> +++ b/fs/nfs/idmap.c
> @@ -272,7 +272,7 @@ nfs_idmap_id(struct idmap *idmap, struct idmap_hashtable *h,
> set_current_state(TASK_UNINTERRUPTIBLE);
> mutex_unlock(&idmap->idmap_im_lock);
> schedule();
> - current->state = TASK_RUNNING;
> + set_current_state(TASK_RUNNING);
> remove_wait_queue(&idmap->idmap_wq, &wq);
> mutex_lock(&idmap->idmap_im_lock);
Probably a dumb question, so please forgive me.
Why are you forcing a memory barrier here, (and also on your other patches).
Is'nt a __set_current_state(TASK_RUNNING); appropriate ?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [KJ][PATCH 03/04]use set_current_state in fs
2007-04-14 9:39 ` Eric Dumazet
@ 2007-04-14 10:16 ` Milind Arun Choudhary
0 siblings, 0 replies; 3+ messages in thread
From: Milind Arun Choudhary @ 2007-04-14 10:16 UTC (permalink / raw)
To: Eric Dumazet; +Cc: kernel-janitors, nfs, linux-kernel, akpm, trond.myklebust
On 11:39 Sat 14 Apr , Eric Dumazet wrote:
> Milind Arun Choudhary a écrit :
> >use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs
> Probably a dumb question, so please forgive me.
no.
you have a valid point
My bad :(
I should probably be enjoying my weekend outdoors..
breath some fresh air...
rather than sending such dumb patches..
ummmmmmmm
booting into windows might help :)
> Why are you forcing a memory barrier here, (and also on your other
> patches).
> Is'nt a __set_current_state(TASK_RUNNING); appropriate ?
it is..
would resend later
Njo!!!
--
Milind Arun Choudhary
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-04-14 10:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-14 8:49 [KJ][PATCH 03/04]use set_current_state in fs Milind Arun Choudhary
2007-04-14 9:39 ` Eric Dumazet
2007-04-14 10:16 ` Milind Arun Choudhary
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox