Re: [PATCH] ALPHA: support graphics on non-zero PCI domains (take 2)

Sam Ravnborg
2007-04-15T12:29:34Z

>
> > > +#ifndef CONFIG_ALPHA_GENERIC
> > > +EXPORT_SYMBOL(tsunami_ioportmap);
> > > +EXPORT_SYMBOL(tsunami_ioremap);
> > > +#endif
> >
> > It looks strange that the function is always defined but conditionally exported.
> > Also usual style is to place EXPORT right after closing brace of function -
> > (with no empty lines in-between).
>
> In a generic kernel the IO functions are never addressed directly,
> only via machine vector, so there is no point in exporting them.
> What about something like EXPORT_SYMBOL_NONGENERIC() macro?
As I wrote it looked strange. Unconditionally exporting them should not harm
and then we are one pair of ifdef/endif shorter?

Nitty gritty detail so do what you think match best.

Sam