public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Danny Kukawka <dkukawka@suse.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stefan Seyfried <seife@suse.de>
Subject: Re: [PATCH] ACPI: more verbose thermal zone shutdown message
Date: Mon, 16 Apr 2007 17:58:45 +0200	[thread overview]
Message-ID: <200704161758.45943.dkukawka@suse.de> (raw)
In-Reply-To: <20070415191107.GD10097@ucw.cz>

On Sonntag, 15. April 2007, Pavel Machek wrote:
> Hi!
> 
> > while debug some strange termal shutdowns I wrote this patch to get more 
> > information in /var/log/messages about the reason for the shutdown. I 
> > think this would be useful in general.
> > 
> > Danny
> > 
> > From: Danny Kukawka <dkukawka@suse.de>
> > Subject: ACPI: more verbose thermal zone shutdown message
> > 
> > add more information to acpi thermal zone shutdown message for easier
> > debugging
> > 
> > Signed-off-by: Danny Kukawka <dkukawka@suse.de>
> 
> Yes, please.
[..]
> Why two printks with same info, and why is one of them WARNING and
> second EMERG?

I think this is  what happen and why there are currently two messages:

* if the temperature is really critical you get (now) this:
----------------
kernel: Critical trip point (102 C) reached on Thermalzone [THM]
kernel: Critical temperature reached (150 C on [THM] with trip point set to: 
102 C), shutting down.
----------------

* and if something send a critical temp event to the thermal zone you get:
----------------
kernel: Critical temperature reached (42 C on [THM] with trip point set to: 
102 C), shutting down.
----------------

Maybe we can delete the first one, since you get now also from second 
message the information if the temperature was really critical or if 
there was an other reason for the shutdown, but in the past this was
IMO needed to differ.

Danny

      reply	other threads:[~2007-04-16 16:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-05 14:15 [PATCH] ACPI: more verbose thermal zone shutdown message Danny Kukawka
2007-04-05 15:12 ` Stefan Seyfried
2007-04-15 19:11 ` Pavel Machek
2007-04-16 15:58   ` Danny Kukawka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704161758.45943.dkukawka@suse.de \
    --to=dkukawka@suse.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=seife@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox