From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Anton Vorontsov <cbou@mail.ru>
Cc: linux-kernel@vger.kernel.org, kernel-discuss@handhelds.org
Subject: Re: [PATCH 7/7] [RFC] APM emulation driver for class batteries
Date: Mon, 16 Apr 2007 21:24:21 +0100 [thread overview]
Message-ID: <20070416202421.GC19713@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20070413135005.GE20618@zarina>
On Fri, Apr 13, 2007 at 05:50:43PM +0400, Anton Vorontsov wrote:
> +static void (*old_apm_get_power_status)(struct apm_power_info*);
> +
> +static int __init apm_battery_init(void)
> +{
> + printk(KERN_INFO "APM Battery Driver\n");
> +
> + old_apm_get_power_status = apm_get_power_status;
> + apm_get_power_status = apm_battery_apm_get_power_status;
> + return 0;
> +}
> +
> +static void __exit apm_battery_exit(void)
> +{
> + apm_get_power_status = old_apm_get_power_status;
> + return;
> +}
Utterly unsafe. What happens if some other module gets loaded which
does this, and then this module is unloaded followed by the other
module. Result: Oops.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-04-16 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-11 23:26 [PATCH 7/7] [RFC] APM emulation driver for class batteries Anton Vorontsov
2007-04-13 13:50 ` Anton Vorontsov
2007-04-16 20:24 ` Russell King [this message]
2007-04-16 21:08 ` Anton Vorontsov
2007-04-16 21:34 ` Russell King
2007-04-20 8:27 ` Pavel Machek
2007-04-16 21:34 ` [Kernel-discuss] " Paul Sokolovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070416202421.GC19713@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=cbou@mail.ru \
--cc=kernel-discuss@handhelds.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox