From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Anton Vorontsov <cbou@mail.ru>
Cc: linux-kernel@vger.kernel.org, kernel-discuss@handhelds.org
Subject: Re: [PATCH 7/7] [RFC] APM emulation driver for class batteries
Date: Mon, 16 Apr 2007 22:34:21 +0100 [thread overview]
Message-ID: <20070416213421.GA32258@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20070416210829.GA5107@zarina>
On Tue, Apr 17, 2007 at 01:08:29AM +0400, Anton Vorontsov wrote:
> On Mon, Apr 16, 2007 at 09:24:21PM +0100, Russell King wrote:
> > Utterly unsafe. What happens if some other module gets loaded which
> > does this, and then this module is unloaded followed by the other
> > module. Result: Oops.
>
> Right. And loading two modules which changing apm_get_power_status
> is a race already. Thus, APM interface needs a mutex.
>
> Or pda_power should be marked "bool" in Kconfig, as it is done
> in arch/arm/common/sharpsl_pm.c. Sharpsl_pm is safe only because it
> can't be a module.
>
> Personally I'd keep things as is for now (i.e. I'd want tristate for
> PDA_POWER, not bool). Later APM API can be fixed.
Experience shows "Later" more often than not means "never", inspite
of what is said at the time the word is used...
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-04-16 21:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-11 23:26 [PATCH 7/7] [RFC] APM emulation driver for class batteries Anton Vorontsov
2007-04-13 13:50 ` Anton Vorontsov
2007-04-16 20:24 ` Russell King
2007-04-16 21:08 ` Anton Vorontsov
2007-04-16 21:34 ` Russell King [this message]
2007-04-20 8:27 ` Pavel Machek
2007-04-16 21:34 ` [Kernel-discuss] " Paul Sokolovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070416213421.GA32258@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=cbou@mail.ru \
--cc=kernel-discuss@handhelds.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox