[PATCH] fix OOM killing processes wrongly thought MPOL_BIND

[PATCH] fix OOM killing processes wrongly thought MPOL_BIND

[Hugh Dickins]

I only have CONFIG_NUMA=y for build testing: surprised when trying a memhog
to see lots of other processes killed with "No available memory (MPOL_BIND)".
memhog is killed correctly once we initialize nodemask in constrained_alloc().

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
Perhaps appropriate for 2.6.20-stable too - regression since 2.6.19.

 mm/oom_kill.c |    2 ++
 1 file changed, 2 insertions(+)

--- 2.6.21-rc7/mm/oom_kill.c	2007-03-26 07:30:54.000000000 +0100
+++ linux/mm/oom_kill.c	2007-04-18 20:18:21.000000000 +0100
@@ -176,6 +176,8 @@ static inline int constrained_alloc(stru
 	struct zone **z;
 	nodemask_t nodes;
 	int node;
+
+	nodes_clear(nodes);
 	/* node has memory ? */
 	for_each_online_node(node)
 		if (NODE_DATA(node)->node_present_pages)

Re: [PATCH] fix OOM killing processes wrongly thought MPOL_BIND

[Christoph Lameter]

On Wed, 18 Apr 2007, Hugh Dickins wrote:

> I only have CONFIG_NUMA=y for build testing: surprised when trying a memhog
> to see lots of other processes killed with "No available memory (MPOL_BIND)".
> memhog is killed correctly once we initialize nodemask in constrained_alloc().
> 
> Signed-off-by: Hugh Dickins <hugh@veritas.com>

Acked-by: Christoph Lameter <clameter@sgi.com>

Re: [PATCH] fix OOM killing processes wrongly thought MPOL_BIND

[William Lee Irwin III]

On Wed, Apr 18, 2007 at 08:35:22PM +0100, Hugh Dickins wrote:
> I only have CONFIG_NUMA=y for build testing: surprised when trying a memhog
> to see lots of other processes killed with "No available memory (MPOL_BIND)".
> memhog is killed correctly once we initialize nodemask in constrained_alloc().
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
> Perhaps appropriate for 2.6.20-stable too - regression since 2.6.19.

This is a clear fix for an uninitialized variable.


Acked-by: William Irwin <bill.irwin@oracle.com>


-- wli

Re: [PATCH] fix OOM killing processes wrongly thought MPOL_BIND

[KAMEZAWA Hiroyuki]

On Wed, 18 Apr 2007 20:35:22 +0100 (BST)
Hugh Dickins <hugh@veritas.com> wrote:

> I only have CONFIG_NUMA=y for build testing: surprised when trying a memhog
> to see lots of other processes killed with "No available memory (MPOL_BIND)".
> memhog is killed correctly once we initialize nodemask in constrained_alloc().
> 

thank you for catching bug.

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>


> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
> Perhaps appropriate for 2.6.20-stable too - regression since 2.6.19.
> 
>  mm/oom_kill.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- 2.6.21-rc7/mm/oom_kill.c	2007-03-26 07:30:54.000000000 +0100
> +++ linux/mm/oom_kill.c	2007-04-18 20:18:21.000000000 +0100
> @@ -176,6 +176,8 @@ static inline int constrained_alloc(stru
>  	struct zone **z;
>  	nodemask_t nodes;
>  	int node;
> +
> +	nodes_clear(nodes);
>  	/* node has memory ? */
>  	for_each_online_node(node)
>  		if (NODE_DATA(node)->node_present_pages)
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>