Re: [patch] CFS scheduler, v3

[William Lee Irwin III <wli@holomorphy.com>]

On Wed, Apr 18, 2007 at 07:50:17PM +0200, Ingo Molnar wrote:
> this is the third release of the CFS patchset (against v2.6.21-rc7), and 
> can be downloaded from:
>    http://redhat.com/~mingo/cfs-scheduler/
> this is a pure "fix reported regressions" release so there's much less 
> churn:
>    5 files changed, 71 insertions(+), 29 deletions(-)
> (the added lines are mostly debug related, not genuine increase in the 
> scheduler's size)

It appears to me that the following can be taken in for mainline
(or rejected for mainline) independently of the rest of the cfs patch.


-- wli

Mark the runqueues ____cacheline_aligned_in_smp to avoid false sharing.

Index: sched/kernel/sched.c
===================================================================
--- sched.orig/kernel/sched.c	2007-04-18 14:10:03.593207728 -0700
+++ sched/kernel/sched.c	2007-04-18 14:11:39.270660075 -0700
@@ -278,7 +278,7 @@
 	struct lock_class_key rq_lock_key;
 };
 
-static DEFINE_PER_CPU(struct rq, runqueues);
+static DEFINE_PER_CPU(struct rq, runqueues) ____cacheline_aligned_in_smp;
 
 static inline int cpu_of(struct rq *rq)
 {