Re: [PATCH] move suspend includes into right place (was Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy))

Adrian Bunk
2007-06-30T00:06:34Z

On Sat, Jun 30, 2007 at 12:44:22AM +0200, Pavel Machek wrote:
> Hi!
>
> > By the way.
> >
> > > diff --git a/kernel/power/power.h b/kernel/power/power.h
> > > index eb461b8..dc13af5 100644
> > > --- a/kernel/power/power.h
> > > +++ b/kernel/power/power.h
> > ^^^^^^^^^^^^^^^^^^^^
> >
> > Don't these definitions need to be exported to userspace? That
> > definitely is not a header file for userspace.
>
> Yes, they do. Does this look like a fix?
> Pavel
>
> ---
>
> Split userinterface part of power.h into separate file.
>...

You should also add it to include/linux/Kbuild.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed