Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)

Ingo Molnar
2007-04-24T20:55:40Z

* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> I have not a frigging clue whether that is the case in suspend2 vs
> uswsusp, but I object to this idiotic argument of counting "kernel
> code". That's simply not a valid argument. It never was.

the raw linecount appears to be the following:

suspend2-2.2.9.12-for-2.6.21-rc6.patch

89 files changed, 16452 insertions(+), 69 deletions(-)

$ suspend-0.5> countlines
32260

so, while it's probably apples to oranges, uswsusp seems to be larger,
while there's at least one feature that it is missing.

also, from the structure of the suspend2 patch it seemed to me that they
could peacefully coexist in the kernel without stepping on each other's
toes - why not do that? Users will then pick the winner.

Ingo