Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)

Johannes Berg
2007-04-26T18:40:19Z

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

On Thu, 2007-04-26 at 20:40 +0200, Rafael J. Wysocki wrote:

> > * it surfaces kernel implementation details about pm_ops and thus makes
> > the whole thing very fragile
>
> Can you elaborate?

Well it tells userspace about pm_ops->enter/prepare/finish etc.
Also, it seems that it needs a "release memory now" operation instead of
just releasing it when the fd is closed?

> > * it has yet another interface (yuck) to determine whether to reboot,
> > shut down etc, doesn't use /sys/power/disk
>
> Yes. In fact it was meant as a replacement for /sys/power/disk at one point.

Heh.

> > * I generally had no idea wtf it is doing in some places
>
> I could have told you if you had asked. :-)

I was offline ;)

> Do we need hibernate_ops at all? There's only one user anyway and I'm not
> sure there will be more of them in the future.

I'm pretty sure there won't be, but there's no way to do it cleanly
without pm_ops since even acpi doesn't do this all the time but only
when some set of conditions is true. Hence, it needs to be able to
determine the availability of the platform mode at run time rather than
build time (build time => we could use weak symbols, arch hooks, ...)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]