Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)

Dumitru Ciobarcianu
2007-04-25T13:03:36Z

On Wed, 2007-04-25 at 07:29 +0000, Pavel Machek wrote:
> > userspace-driven-suspend is already in the kernel, today. So it's not
> > really "two versions side by side doing the same thing", but more of:
> >
> > A B C + D E F G H
> >
> > where "ABC" is used by the uswsusp code today, and "ABCDEFGH" is used by
> > suspend2. So any "suspend2 merge" would largely be about adding "DEFGH".
>
> Actually, we have 'D H' in kernel, today. It is called swsusp...
> (Encryption, swapFile support and Graphical progress are missing from
> today's kernel.)

Please stop using FUD.
Graphical progress it's not in the kernel, even with suspend2.

>
> > My original mail was about the following thing: i tried the suspend2
> > patch (which just makes "echo disk > /sys/power/state" work as expected,
> > as long as you give the booting up kernel image an idea about where the
>
> ..and it means that 'echo disk > ...' should work w/o suspend2 patch,
> too. (Just try it). You'll miss compression part, but that provides
> only small speedup.

I beg to differ:
Compressed 904687616 bytes into 418828687 (53 percent compression).

Almost 500mb less to write (did I mention it writes the full image?).
Now imagine the time it takes to write that with those pesky 4200rpm
laptop hdds.

--
Cioby

"Mr Linus, how do you debug the kernel, what tools do you use?"
"Ever heard of prinf ?"
(From an presentation at the "Politehnica" University of Bucharest, 1995)