Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags

Rafael J. Wysocki
2007-04-23T20:02:34Z

Hi,

On Monday, 23 April 2007 06:09, Satyam Sharma wrote:
> Hi Rafael,
>
[--snip--]
>
> Also, I do have several gripes against the naming of some of these functions:
>
> > static inline int freezing(struct task_struct *p)
>
> This could be called task_should_freeze().
>
> > /*
> > - * Sometimes we may need to cancel the previous 'freeze' request
> > + * Cancel the previous 'freeze' request
> > */
> > static inline void do_not_freeze(struct task_struct *p)
>
> This definitely needs to be undo_freeze() or unfreeze().
> do_not_freeze() sounds like what freeze_exempt() does.
>
> > static inline void frozen_process(struct task_struct *p)
>
> frozen_process() sounds like what frozen() is supposed to do. This
> could instead be mark_task_frozen(), or even mark_frozen(), because
> only the current task can ever mark *itself* frozen before freezing
> itself.
>
> > static inline void freezer_do_not_count(void)
> > static inline void freezer_count(void)
>
> These could be called freezer_skip() and freezer_do_not_skip(). Better
> to stick to consistent naming / terminology.

Well, I agree that the names are not the best ones, but I'd like to avoid
changing the existing names in this particular patch.

We can change them later, on top of it.

Greetings,
Rafael