Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop race

Ingo Molnar
2007-04-20T18:32:25Z

* Andrew Morton <akpm@linux-foundation.org> wrote:

> > > I mean, we already have four of them (PF_NOFREEZE, PF_FROZEN,
> > > PF_FREEZER_SKIP, TIF_FREEZE), and you will need to introduce two
> > > more for the freezer-based CPU hotplug, so if yet another one is
> > > needed, that will make up almost a separate u8 field ...
> >
> > I am perfectly ok with it. But I am not sure if everybody would
> > agree to have another field in the task struct, though in this case
> > it does make sense :-)
>
> OK by me. You might want to consider making that fields's locking
> protocol be set_bit(), clear_bit(), etc rather than task_lock().

is OK to me too, the extra field isnt a problem.

Ingo