Re: const struct pci_driver [Was: [RFC 2/2] Input: phantom, add a new driver]

[Greg KH <gregkh@suse.de>]

On Fri, Apr 20, 2007 at 10:28:46AM +0200, Jiri Slaby wrote:
> Andrew Morton napsal(a):
> > On Tue, 17 Apr 2007 22:02:10 +0200 (CEST) Jiri Slaby <jirislaby@gmail.com> wrote:
> > 
> >> phantom, add a new driver
> [...]
> >> +static struct pci_driver phantom_pci_driver = {
> >> +	.name = "phantom",
> >> +	.id_table = phantom_pci_tbl,
> >> +	.probe = phantom_probe,
> >> +	.remove = __devexit_p(phantom_remove),
> >> +	.suspend = phantom_suspend,
> >> +	.resume = phantom_resume
> >> +};
> > 
> > This goes into the read/write section.  Make it const?
> 
> Hmm, good question, I don't know the answer. Why are not pci_driver structs
> const, Greg?

Because the pci core sets the needed pci_driver.driver structure fields
that the driver core needs in order to properly hook up things.

I'm considering a change to this that would allow pci (and all other)
driver structures be const, and then dynamically create the needed
driver core structure based on this "template" which would also let us
do some other things that the driver core wants, but that work is a few
months away.  When/if I get to that, I'll go through and mark all of the
driver structures const to move them to the read-only kernel section.

thanks,

greg k-h