From: Dave Jones <davej@redhat.com>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, Andi Kleen <ak@suse.de>
Subject: Re: [RFC PATCH 1/3] x86: use defined names for all CPU feature flags
Date: Sat, 21 Apr 2007 02:48:16 -0400 [thread overview]
Message-ID: <20070421064816.GA4293@redhat.com> (raw)
In-Reply-To: <46294444.1050608@redhat.com>
On Fri, Apr 20, 2007 at 06:52:52PM -0400, Chuck Ebbert wrote:
> --- 2.6.21-rc7-d390.orig/arch/x86_64/kernel/setup.c
> +++ 2.6.21-rc7-d390/arch/x86_64/kernel/setup.c
> @@ -576,7 +576,7 @@ static void __cpuinit init_amd(struct cp
>
> /* Bit 31 in normal CPUID used for nonstandard 3DNow ID;
> 3DNow is IDd by bit 31 in extended CPUID (1*32+31) anyway */
> - clear_bit(0*32+31, &c->x86_capability);
> + clear_bit(X86_FEATURE_PBE, &c->x86_capability);
The comment suggests this should be X86_FEATURE_3DNOW
Same for the other instances.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-04-21 6:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 22:49 [RFC PATCH 0/3] Clean up x86 CPU feature setup Chuck Ebbert
2007-04-20 22:52 ` [RFC PATCH 1/3] x86: use defined names for all CPU feature flags Chuck Ebbert
2007-04-21 6:48 ` Dave Jones [this message]
2007-04-21 9:47 ` Andi Kleen
2007-04-21 21:19 ` Alan Cox
2007-04-20 22:53 ` [RFC PATCH 2/3] x86: new API for modifying " Chuck Ebbert
2007-04-20 22:54 ` [RFC PATCH 3/3] x86: use the x86 CPU feature API Chuck Ebbert
2007-04-21 9:41 ` [RFC PATCH 0/3] Clean up x86 CPU feature setup Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070421064816.GA4293@redhat.com \
--to=davej@redhat.com \
--cc=ak@suse.de \
--cc=cebbert@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox