public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/3] Clean up x86 CPU feature setup
Date: Sat, 21 Apr 2007 11:41:16 +0200	[thread overview]
Message-ID: <200704211141.16589.ak@suse.de> (raw)
In-Reply-To: <4629438C.4070209@redhat.com>

On Saturday 21 April 2007 00:49:48 Chuck Ebbert wrote:
> x86 CPU feature flag setup has become impossible to debug.
> Every user just does set_bit()/clear_bit() or writes the
> entire set to change the flags, so there's no way to trace
> how they're being set.

Just use grep or printk? It is not *that* complicated. 

> This patchset creates an API and debug messages for tracking
> how the flags get set. It's not nearly done, but I want to
> know whether or not to continue.

I don't see any particular value. In theory we could add a "debug API"
for nearly everything, but in practice it is usually not needed.
Like here.

-Andi

      parent reply	other threads:[~2007-04-21  9:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-20 22:49 [RFC PATCH 0/3] Clean up x86 CPU feature setup Chuck Ebbert
2007-04-20 22:52 ` [RFC PATCH 1/3] x86: use defined names for all CPU feature flags Chuck Ebbert
2007-04-21  6:48   ` Dave Jones
2007-04-21  9:47   ` Andi Kleen
2007-04-21 21:19   ` Alan Cox
2007-04-20 22:53 ` [RFC PATCH 2/3] x86: new API for modifying " Chuck Ebbert
2007-04-20 22:54 ` [RFC PATCH 3/3] x86: use the x86 CPU feature API Chuck Ebbert
2007-04-21  9:41 ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704211141.16589.ak@suse.de \
    --to=ak@suse.de \
    --cc=cebbert@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox