From: Akinobu Mita <akinobu.mita@gmail.com>
To: Andi Kleen <andi@firstfloor.org>,
Scott Porter <scott@opengridcomputing.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org, Pekka Enberg <penberg@cs.helsinki.fi>
Subject: [PATCH] fault injection: fix failslab with CONFIG_NUMA
Date: Sun, 22 Apr 2007 18:11:08 +0900 [thread overview]
Message-ID: <20070422091108.GB4246@APFDCB5C> (raw)
In-Reply-To: <20070422090930.GA4246@APFDCB5C>
Currently failslab injects failures into ____cache_alloc().
But with enabling CONFIG_NUMA it's not enough to let actual
slab allocator functions (kmalloc, kmem_cache_alloc, ...) return NULL.
This patch moves fault injection hook inside of __cache_alloc() and
__cache_alloc_node(). These are lower call path than ____cache_alloc()
and enable to inject faulures to slab allocators with CONFIG_NUMA.
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
mm/slab.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
Index: 2.6-git/mm/slab.c
===================================================================
--- 2.6-git.orig/mm/slab.c
+++ 2.6-git/mm/slab.c
@@ -3142,7 +3142,7 @@ static int __init failslab_debugfs(void)
struct dentry *dir;
int err;
- err = init_fault_attr_dentries(&failslab.attr, "failslab");
+ err = init_fault_attr_dentries(&failslab.attr, "failslab");
if (err)
return err;
dir = failslab.attr.dentries.dir;
@@ -3180,9 +3180,6 @@ static inline void *____cache_alloc(stru
check_irq_off();
- if (should_failslab(cachep, flags))
- return NULL;
-
ac = cpu_cache_get(cachep);
if (likely(ac->avail)) {
STATS_INC_ALLOCHIT(cachep);
@@ -3374,6 +3371,9 @@ __cache_alloc_node(struct kmem_cache *ca
unsigned long save_flags;
void *ptr;
+ if (should_failslab(cachep, flags))
+ return NULL;
+
cache_alloc_debugcheck_before(cachep, flags);
local_irq_save(save_flags);
@@ -3444,6 +3444,9 @@ __cache_alloc(struct kmem_cache *cachep,
unsigned long save_flags;
void *objp;
+ if (should_failslab(cachep, flags))
+ return NULL;
+
cache_alloc_debugcheck_before(cachep, flags);
local_irq_save(save_flags);
objp = __do_cache_alloc(cachep, flags);
next prev parent reply other threads:[~2007-04-22 9:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 18:55 Fault Injection issues: stacktrace x86_64 and failslab NUMA Scott Porter
2007-04-21 21:52 ` Scott Porter
2007-04-21 22:10 ` Andi Kleen
2007-04-22 7:06 ` Akinobu Mita
2007-04-22 9:09 ` [PATCH] fault injection: disable stacktrace filter for x86-64 Akinobu Mita
2007-04-22 9:11 ` Akinobu Mita [this message]
2007-04-22 9:12 ` [PATCH] fault injection: add entry to MAINTAINERS Akinobu Mita
2007-04-23 5:05 ` [PATCH] fault injection: fix failslab with CONFIG_NUMA Pekka J Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070422091108.GB4246@APFDCB5C \
--to=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=scott@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox