From: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: emoenke@gwdg.de, minyard@wf-rch.cirr.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use spinlock instead of binary mutex in CDU-31A driver
Date: Mon, 23 Apr 2007 07:42:14 +0200 [thread overview]
Message-ID: <20070423054213.GQ5013@traven> (raw)
In-Reply-To: <p737is43sah.fsf@bingen.suse.de>
El Mon, Apr 23, 2007 at 01:25:58AM +0200 Andi Kleen ha dit:
> Matthias Kaehlcke <matthias.kaehlcke@gmail.com> writes:
>
> > -static DECLARE_MUTEX(sony_sem); /* Semaphore for drive hardware access */
> > +static DEFINE_MUTEX(sony_mtx); /* Mutex for drive hardware access */
>
> That's not a spinlock. Also normally some rationale is added to the
> description for a change?
sorry i messed up the description of the change, i meant mutex instead
of spinlock (in the last days i reported some spinlock related bugs
...).
the rationale is that according to http://lwn.net/Articles/167034/
binary semaphores that aren't given in interrupt context or
locked and unlocked by different processes should be replaced by
mutexes
thanks for your comments
--
Matthias Kaehlcke
Linux Application Developer
Barcelona
La posibilidad de realizar un suenyo es lo
que hace que la vida sea interesante
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
prev parent reply other threads:[~2007-04-23 5:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-22 21:35 [PATCH] use spinlock instead of binary mutex in CDU-31A driver Matthias Kaehlcke
2007-04-22 23:25 ` Andi Kleen
2007-04-23 5:42 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070423054213.GQ5013@traven \
--to=matthias.kaehlcke@gmail.com \
--cc=andi@firstfloor.org \
--cc=emoenke@gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@wf-rch.cirr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox