public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: William Heimbigner <icxcnika@mar.tar.cc>
Cc: linux-kernel@vger.kernel.org, Peter Osterlund <petero2@telia.com>,
	Jens Axboe <jens.axboe@oracle.com>
Subject: Re: BUG: Null pointer dereference in fs/open.c
Date: Mon, 23 Apr 2007 22:17:26 -0700	[thread overview]
Message-ID: <20070423221726.ccfa982c.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0704240507110.25153@server.thyself>

On Tue, 24 Apr 2007 05:10:04 +0000 (GMT) William Heimbigner <icxcnika@mar.tar.cc> wrote:

> > --- a/drivers/block/pktcdvd.c~packet-fix-error-handling
> > +++ a/drivers/block/pktcdvd.c
> > @@ -777,7 +777,8 @@ static int pkt_generic_packet(struct pkt
> > 		rq->cmd_flags |= REQ_QUIET;
> >
> > 	blk_execute_rq(rq->q, pd->bdev->bd_disk, rq, 0);
> > -	ret = rq->errors;
> > +	if (rq->errors)
> > +		ret = -EIO;
> > out:
> > 	blk_put_request(rq);
> > 	return ret;
> > _
> 
> This patch fixes (or conceals?) the oops.
> 

Fixes.  But does the packet driver actually work OK for you?  Writes
files and stuff like that?

  reply	other threads:[~2007-04-24  5:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-22 23:13 BUG: Null pointer dereference (2.6.21-rc7) William Heimbigner
2007-04-23  8:00 ` Andrew Morton
2007-04-23 13:58   ` William Heimbigner
2007-04-23 16:39     ` William Heimbigner
2007-04-24  4:09       ` BUG: Null pointer dereference in fs/open.c William Heimbigner
     [not found]         ` <20070423215810.5a24ed9a.akpm@linux-foundation.org>
2007-04-24  5:10           ` William Heimbigner
2007-04-24  5:17             ` Andrew Morton [this message]
2007-04-24  5:44               ` William Heimbigner
2007-04-24  5:56                 ` Andrew Morton
2007-04-25  7:48                 ` Andrew Morton
2007-04-25 22:53                   ` William Heimbigner
2007-04-25 23:05                     ` Andrew Morton
2007-04-26  0:48                       ` William Heimbigner
2007-04-26  6:39                         ` Jens Axboe
2007-04-26  6:33                       ` Jens Axboe
2007-04-24 20:46           ` Peter Osterlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070423221726.ccfa982c.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=icxcnika@mar.tar.cc \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petero2@telia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox