From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161552AbXDXFRs (ORCPT ); Tue, 24 Apr 2007 01:17:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161554AbXDXFRs (ORCPT ); Tue, 24 Apr 2007 01:17:48 -0400 Received: from smtp1.linux-foundation.org ([65.172.181.25]:53290 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161552AbXDXFRr (ORCPT ); Tue, 24 Apr 2007 01:17:47 -0400 Date: Mon, 23 Apr 2007 22:17:26 -0700 From: Andrew Morton To: William Heimbigner Cc: linux-kernel@vger.kernel.org, Peter Osterlund , Jens Axboe Subject: Re: BUG: Null pointer dereference in fs/open.c Message-Id: <20070423221726.ccfa982c.akpm@linux-foundation.org> In-Reply-To: References: <20070423010032.c89e8d32.akpm@linux-foundation.org> <20070423215810.5a24ed9a.akpm@linux-foundation.org> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Apr 2007 05:10:04 +0000 (GMT) William Heimbigner wrote: > > --- a/drivers/block/pktcdvd.c~packet-fix-error-handling > > +++ a/drivers/block/pktcdvd.c > > @@ -777,7 +777,8 @@ static int pkt_generic_packet(struct pkt > > rq->cmd_flags |= REQ_QUIET; > > > > blk_execute_rq(rq->q, pd->bdev->bd_disk, rq, 0); > > - ret = rq->errors; > > + if (rq->errors) > > + ret = -EIO; > > out: > > blk_put_request(rq); > > return ret; > > _ > > This patch fixes (or conceals?) the oops. > Fixes. But does the packet driver actually work OK for you? Writes files and stuff like that?