From: Andrew Morton <akpm@linux-foundation.org>
To: Gerd Hoffmann <kraxel@suse.de>
Cc: linux-kernel@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>,
Ralf Baechle <ralf@linux-mips.org>, Andi Kleen <ak@suse.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [patch v2] Fixes and cleanups for earlyprintk aka boot console.
Date: Mon, 23 Apr 2007 23:42:40 -0700 [thread overview]
Message-ID: <20070423234240.29427438.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070315154638.944768000@suse.de>
On Thu, 15 Mar 2007 16:46:39 +0100 Gerd Hoffmann <kraxel@suse.de> wrote:
> The console subsystem already has an idea of a boot console, using the
> CON_BOOT flag. The implementation has some flaws though. The major
> problem is that presence of a boot console makes register_console()
> ignore any other console devices (unless explicitly specified on the
> kernel command line).
>
> This patch fixes the console selection code to *not* consider a boot
> console a full-featured one, so the first non-boot console registering
> will become the default console instead. This way the unregister call
> for the boot console in the register_console() function actually
> triggers and the handover from the boot console to the real console
> device works smoothly. Added a printk for the handover, so you know
> which console device the output goes to when the boot console stops
> printing messages.
>
> The disable_early_printk() call is obsolete with that patch, explicitly
> disabling the early console isn't needed any more as it works
> automagically with that patch.
>
> I've walked through the tree, dropped all disable_early_printk()
> instances found below arch/ and tagged the consoles with CON_BOOT if
> needed. The code is tested on x86, sh (thanks to Paul) and mips
> (thanks to Ralf).
>
> Changes to last version: Rediffed against -rc3, adapted to mips
> cleanups by Ralf, fixed "udbg-immortal" cmd line arg on powerpc.
I get this, across netconsole:
[17179569.184000] console handover: boot [earlyvga_f\x11_0] -> real [tty0]
wanna take a look at why there's cruft in bootconsole->name please?
in grub.conf I have
kernel /boot/bzImage-2.6.21-rc7-mm1 ro root=LABEL=/ rhgb vga=0x263 netconsole=4444@192.168.2.10/eth0,5145@192.168.2.33/00:0D:56:C6:C6:CC profile=1 earlyprintk=vga resume=8:5 time
and I'm using
http://userweb.kernel.org/~akpm/config-sony.txt
Thanks.
next prev parent reply other threads:[~2007-04-24 6:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-15 15:46 [patch v2] Fixes and cleanups for earlyprintk aka boot console Gerd Hoffmann
2007-03-15 20:58 ` John Stoffel
2007-03-16 8:10 ` Gerd Hoffmann
2007-03-29 16:37 ` Olaf Dabrunz
2007-04-03 15:42 ` John Stoffel
2007-04-11 18:33 ` Olaf Dabrunz
2007-04-24 6:42 ` Andrew Morton [this message]
2007-04-24 14:04 ` Gerd Hoffmann
2007-04-24 17:27 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070423234240.29427438.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jeremy@goop.org \
--cc=kraxel@suse.de \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox