Re: [patch] CFS scheduler, -v5

Ingo Molnar
2007-04-23T09:26:22Z

* Nick Piggin <npiggin@suse.de> wrote:

> > yeah - but they'll all be quad core, so the SMP timeslice
> > multiplicator should do the trick. Most of the CFS testers use
> > single-CPU systems.
>
> But desktop users could have have quad thread and even 8 thread CPUs
> soon, [...]

SMT is indeed an issue, so i think what should be used to scale
timeslices isnt num_online_cpus(), but the sum of all CPU's ->cpu_power
value (scaled down by SCHED_LOAD_SCALE). That way if the thread is not a
'full CPU', then the scaling will be proportionally smaller. Can you see
any hole in that?

Ingo