From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Hugh Dickins <hugh@veritas.com>, Nick Piggin <npiggin@suse.de>,
linux-kernel@vger.kernel.org, pj@sgi.com
Subject: Re: Pagecache: find_or_create_page does not call a proper page allocator function
Date: Tue, 24 Apr 2007 13:20:18 -0700 [thread overview]
Message-ID: <20070424132018.f7ee0a2a.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0704241311390.13005@schroedinger.engr.sgi.com>
On Tue, 24 Apr 2007 13:12:42 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:
> On Tue, 24 Apr 2007, Andrew Morton wrote:
>
> > > A highmem page can have buffers???
> >
> > yep. Take a 4k page which is stored in four discontiguous 1k disk blocks. The
> > data at page_buffers(page) is the sole way in which we track which parts of
> > the page belong to which blocks of the disk.
>
> But I see no use of kmap for buffer access? The data is not accessible.
>
The kernel rarely has a need to actually read or write the page's contents
with the CPU. On those occasions where it does, it will use kmap. Search
for zero_user_page() and kmap in rc7-mm1's fs/buffer.c
But that's file pagecache, which can be in highmem. File metadata is accessed
within the filesystems without kmapping. This:
box:/usr/src/linux-2.6.21-rc7> grep '[-]>b_data' fs/*/*.c | wc -l
1017
explains why that never got fixed.
prev parent reply other threads:[~2007-04-24 20:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 21:11 Pagecache: find_or_create_page does not call a proper page allocator function Christoph Lameter
2007-04-23 21:29 ` Andrew Morton
2007-04-23 21:37 ` Christoph Lameter
2007-04-23 22:33 ` Christoph Lameter
2007-04-23 22:42 ` Christoph Lameter
2007-04-23 22:42 ` Andrew Morton
2007-04-24 13:09 ` Hugh Dickins
2007-04-24 17:11 ` Andrew Morton
2007-04-24 19:06 ` Hugh Dickins
2007-04-24 19:55 ` Christoph Lameter
2007-04-24 20:16 ` Hugh Dickins
2007-04-24 20:30 ` Christoph Lameter
2007-04-24 20:42 ` Andrew Morton
2007-04-24 20:44 ` Christoph Lameter
2007-04-24 20:53 ` Andrew Morton
2007-04-24 20:58 ` Christoph Lameter
2007-04-24 21:24 ` Andrew Morton
2007-04-24 21:28 ` Christoph Lameter
2007-04-24 17:38 ` Christoph Lameter
2007-04-24 17:45 ` Hugh Dickins
2007-04-24 17:48 ` Christoph Lameter
2007-04-24 17:51 ` Andrew Morton
2007-04-24 17:56 ` Christoph Lameter
2007-04-24 17:45 ` Christoph Lameter
2007-04-24 18:53 ` Hugh Dickins
2007-04-24 19:34 ` Christoph Lameter
2007-04-24 19:49 ` Andrew Morton
2007-04-24 19:59 ` Christoph Lameter
2007-04-24 20:10 ` Andrew Morton
2007-04-24 20:12 ` Christoph Lameter
2007-04-24 20:20 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070424132018.f7ee0a2a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox