From: Jens Axboe <jens.axboe@oracle.com>
To: Vasily Tarasov <vtaras@openvz.org>
Cc: LKML <linux-kernel@vger.kernel.org>, OVZDL <devel@openvz.org>
Subject: Re: [PATCH] cfq: get rid of cfqq hash
Date: Tue, 24 Apr 2007 20:29:07 +0200 [thread overview]
Message-ID: <20070424182906.GF27887@kernel.dk> (raw)
In-Reply-To: <20070424172228.GC27887@kernel.dk>
On Tue, Apr 24 2007, Jens Axboe wrote:
> - if (key != CFQ_KEY_ASYNC)
> + if (!is_sync)
> cfq_mark_cfqq_idle_window(cfqq);
> + else
> + cfq_mark_cfqq_sync(cfqq);
Woops, should be
if (is_sync) {
cfq_mark_cfqq_idle_window(cfqq);
cfq_mark_cfqq_sync(cfqq);
}
of course.
> +static struct cfq_io_context *
> +cfq_get_io_context_noalloc(struct cfq_data *cfqd, struct task_struct *tsk)
> +{
> + struct cfq_io_context *cic = NULL;
> + struct io_context *ioc;
> +
> + ioc = tsk->io_context;
> + if (ioc)
> + cic = cfq_cic_rb_lookup(cfqd, ioc);
> +
> + return cic;
> +}
I'll change that to just call cfq_cic_rb_lookup(), returning NULL for
NULL ioc.
--
Jens Axboe
next prev parent reply other threads:[~2007-04-24 18:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 13:53 [PATCH] cfq: get rid of cfqq hash Vasily Tarasov
2007-04-24 17:02 ` Jens Axboe
2007-04-24 17:22 ` Jens Axboe
2007-04-24 18:29 ` Jens Axboe [this message]
2007-04-24 18:33 ` Jens Axboe
2007-04-25 11:31 ` Vasily Tarasov
2007-04-25 6:58 ` Jens Axboe
2007-04-25 7:27 ` Jens Axboe
2007-04-25 11:50 ` Vasily Tarasov
2007-04-25 7:57 ` Jens Axboe
2007-04-25 10:27 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2007-04-24 11:53 Vasily Tarasov
2007-04-24 12:27 ` Jens Axboe
2007-04-24 12:51 ` Vasily Tarasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070424182906.GF27887@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vtaras@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox