From: Andi Kleen <ak@suse.de>
To: Ashok Raj <ashok.raj@intel.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, gregkh@suse.de,
muli@il.ibm.com, asit.k.mallick@intel.com,
suresh.b.siddha@intel.com, anil.s.keshavamurthy@intel.com,
arjan@linux.intel.com, shaohua.li@intel.com
Subject: Re: [Intel IOMMU][patch 1/8] ACPI support for Intel Virtualization Technology for Directed I/O
Date: Tue, 24 Apr 2007 20:50:48 +0200 [thread overview]
Message-ID: <200704242050.49253.ak@suse.de> (raw)
In-Reply-To: <20070424061037.361212000@intel.com>
> +config DMAR
> + bool "Support for DMA Remapping Devices (EXPERIMENTAL)"
> + depends on PCI_MSI && ACPI && EXPERIMENTAL
> + help
> + Support DMA Remapping Devices. The devices are reported via
> + ACPI tables and includes pci device scope under each DMA
> + remapping device.
The description needs to explain what a dma remapping device is.
And some high level comment here what this file does.
> +
> +LIST_HEAD(dmar_drhd_units);
> +LIST_HEAD(dmar_rmrr_units);
Comment describing what lock protects those lists?
In fact there seems to be no locking. What about hotplug?
>
> +
> + dmar = (struct acpi_table_dmar *)table;
> + if (!dmar) {
> + printk (KERN_WARNING PREFIX "Unable to map DMAR\n");
> + return -ENODEV;
> + }
Shouldn't that be wherever the table is mapped. Or is it not needed?
-Andi
next prev parent reply other threads:[~2007-04-24 19:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 6:02 [Intel IOMMU][patch 0/8] Intel IOMMU Support Ashok Raj
2007-04-24 6:03 ` [Intel IOMMU][patch 1/8] ACPI support for Intel Virtualization Technology for Directed I/O Ashok Raj
2007-04-24 18:50 ` Andi Kleen [this message]
2007-04-24 20:17 ` Ashok Raj
2007-04-24 6:03 ` [Intel IOMMU][patch 2/8] Some generic search functions required to lookup device relationships Ashok Raj
2007-04-24 6:03 ` [Intel IOMMU][patch 3/8] Generic hardware support for Intel IOMMU Ashok Raj
2007-04-24 19:27 ` Andi Kleen
2007-04-24 20:59 ` Ashok Raj
2007-04-25 1:17 ` Shaohua Li
2007-04-25 6:53 ` Andi Kleen
2007-04-24 6:03 ` [Intel IOMMU][patch 4/8] Supporting Zero Length Reads in " Ashok Raj
2007-04-24 19:28 ` Andi Kleen
2007-04-24 20:42 ` Ashok Raj
2007-04-24 21:00 ` David Miller
2007-04-24 6:03 ` [Intel IOMMU][patch 5/8] Graphics driver workarounds to provide unity map Ashok Raj
2007-04-24 6:03 ` [Intel IOMMU][patch 6/8] Doc updates for Intel Virtualization Technology for Directed I/O Ashok Raj
2007-04-24 6:03 ` [Intel IOMMU][patch 7/8] Support for legacy ISA devices Ashok Raj
2007-04-24 19:31 ` Andi Kleen
2007-04-24 20:33 ` Arjan van de Ven
2007-04-24 20:39 ` Ashok Raj
2007-04-24 6:03 ` [Intel IOMMU][patch 8/8] Preserve some Virtual Address when devices cannot address entire range Ashok Raj
2007-04-24 19:33 ` Andi Kleen
2007-04-24 20:33 ` Ashok Raj
2007-04-24 21:12 ` Andi Kleen
2007-04-24 21:23 ` David Miller
2007-04-24 21:32 ` Roland Dreier
2007-04-24 21:47 ` David Miller
2007-04-24 21:38 ` Ashok Raj
2007-04-24 21:50 ` David Miller
2007-04-24 22:03 ` Andi Kleen
2007-04-24 22:26 ` Ashok Raj
2007-04-25 1:12 ` H. Peter Anvin
2007-04-25 6:55 ` Andi Kleen
2007-04-24 23:22 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2007-04-23 16:38 [Intel IOMMU][patch 0/8] Intel IOMMU Support Ashok Raj
2007-04-23 16:38 ` [Intel IOMMU][patch 1/8] ACPI support for Intel Virtualization Technology for Directed I/O Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704242050.49253.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arjan@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=shaohua.li@intel.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox