From: Andi Kleen <andi@firstfloor.org>
To: Andi Kleen <andi@firstfloor.org>, Andrew Morton <akpm@osdl.org>,
Oleg Nesterov <oleg@tv-sign.ru>,
Steven Pratt <slpratt@austin.ibm.com>,
Ram Pai <linuxram@us.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] on-demand readahead
Date: Wed, 25 Apr 2007 18:08:44 +0200 [thread overview]
Message-ID: <20070425160844.GA30132@one.firstfloor.org> (raw)
In-Reply-To: <20070425160400.GA27954@mail.ustc.edu.cn>
> Yeah, the on-demand readahead can avoid _all_ lookups for small in-cache files.
How?
> But what do you mean by AS?
struct address_space
> > You seem to have a lot of magic numbers. They probably all need symbols and
> > explanations.
>
> The magic numbers are for easier testings, and will be removed in
> future. For now, they enables convenient comparing of the two
> algorithms in one kernel.
I mean the 16 and 4 not the sysctl
>
> If this new algorithm has been further tested and approved, I'll
> re-submit the patch in a cleaner, standalone form. The adaptive
> readahead patches can be dropped then. They may better be reworked as
> a kernel module.
If they actually help and don't cause regressions they shouldn't be a module,
but integrated eventually Just it has to be all step by step.
>
> > Your white space also needs some work.
>
> White space in patch description?
In the code indentation.
-Andi
next prev parent reply other threads:[~2007-04-25 16:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070425131133.GA26863@mail.ustc.edu.cn>
2007-04-25 13:11 ` [RFC][PATCH] on-demand readahead Fengguang Wu
2007-04-25 14:37 ` Andi Kleen
[not found] ` <20070425160400.GA27954@mail.ustc.edu.cn>
2007-04-25 16:04 ` Fengguang Wu
2007-04-26 6:58 ` Andrew Morton
2007-04-25 16:08 ` Andi Kleen [this message]
[not found] ` <20070426011655.GA6373@mail.ustc.edu.cn>
2007-04-26 1:16 ` Fengguang Wu
2007-05-02 10:02 ` [RFC] splice() and readahead interaction Eric Dumazet
[not found] ` <f6b15c890705050204l11045ba3w66c8c4ae0ac3407f@mail.gmail.com>
2007-05-07 21:54 ` Andrew Morton
2007-05-10 19:53 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070425160844.GA30132@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=oleg@tv-sign.ru \
--cc=slpratt@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox