Re: [PATCH 23/25] xen: Lockdep fixes for xen-netfront

Herbert Xu
2007-04-24T03:23:08Z

Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
> @@ -1212,10 +1212,10 @@ static int netif_poll(struct net_device
> int pages_flipped = 0;
> int err;
>
> - spin_lock(&np->rx_lock);
> + spin_lock_bh(&np->rx_lock);
>
> if (unlikely(!netfront_carrier_ok(np))) {
> - spin_unlock(&np->rx_lock);
> + spin_unlock_bh(&np->rx_lock);

You don't need to disable BH in netif_poll since it's always called
with BH disabled.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt