Re: [PATCH 03/25] xen: Add nosegneg capability to the vsyscall page notes

Roland McGrath
2007-04-23T23:30:06Z

> + * It should contain:
> + * hwcap 0 nosegneg
> + * to match the mapping of bit to name that we give here.

This needs to be "hwcap 0 nosegneg" to match:

> +NOTE_KERNELCAP_BEGIN(1, 2)
> +NOTE_KERNELCAP(1, "nosegneg")
> +NOTE_KERNELCAP_END

The actual bits you are using should be fine. (You're intentionally
skipping bit 0 to work around hold glibc bugs, which you might want to add
to the comments. Also a comment or perhaps using 1<<1 syntax would make it
more clear that "2" is the bit mask containing bit 1 and that's why it has
to be 2, and not because of some other magical property of 2.) But if
kernel packagers don't write the matching bit number in their ld.so.conf.d
files, then ld.so.cache lookups won't work right.

Thanks,
Roland