From: Arnd Bergmann <arnd@arndb.de>
To: Sergey Yanovich <ynvich@gmail.com>
Cc: linux-kernel@vger.kernel.org, drzeus-mmc@drzeus.cx
Subject: Re: [PATCH] [mmc] [tifm] Reduces delay in card insert/removal
Date: Thu, 26 Apr 2007 01:00:30 +0200 [thread overview]
Message-ID: <200704260100.31035.arnd@arndb.de> (raw)
In-Reply-To: <11775383661213-git-send-email-ynvich@gmail.com>
On Wednesday 25 April 2007, Sergey Yanovich wrote:
> First, I tried to replace 'mdelay' with 'msleep' and put it after
> 'unlock'. It gives a certain oops.
>
> With the delay of 50 msec driver remains stable. It has something
> to do with hardware initialization, so this value should not be
> affected by CPU speed. I hope so.
>
> Signed-off-by: Sergey Yanovich <ynvich@gmail.com>
No, 50ms is still too much, I'd consider every instance of 'mdelay'
to be a bug in general, except maybe with exceptionally broken
hardware, which I don't think this is.
The reason that it gave you an oops is that you call it from
a tasklet. You have to convert the tasklet to a workqueue at the
same time if you want to sleep inside it. In fact, it might
be a good idea to convert all the tasklets in that driver
to use schedule_work instead.
Arnd <><
next prev parent reply other threads:[~2007-04-25 23:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 20:53 [mmc] alternative TI FM MMC/SD driver for 2.6.21-rc7 Sergey Yanovich
2007-04-19 22:56 ` Arnd Bergmann
2007-04-20 9:22 ` Sergey Yanovich
[not found] ` <5e03dd4e0b14c8155162a5b5b1cea4ed7e04cea3.1177536862.git.ynvich@gmail.com>
2007-04-25 21:44 ` [PATCH] [mmc] Removes custom debug macro Sergey Yanovich
[not found] ` <033d5e9dede8853d54e81bc9c1435a2b7915518b.1177536863.git.ynvich@gmail.com>
2007-04-25 21:44 ` [PATCH] [mmc] [tifm] Reduces delay in card insert/removal Sergey Yanovich
2007-04-25 21:59 ` Sergey Yanovich
2007-04-25 23:00 ` Arnd Bergmann [this message]
2007-04-25 22:13 ` Sergey Yanovich
2007-04-25 21:59 ` [PATCH] [mmc] Removes custom debug macro Sergey Yanovich
2007-04-25 22:15 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704260100.31035.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=drzeus-mmc@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=ynvich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox