From: Dave Jones <davej@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sworks-agp: Switch to PCI ref counting APIs
Date: Thu, 26 Apr 2007 00:26:17 -0400 [thread overview]
Message-ID: <20070426042617.GC11278@redhat.com> (raw)
In-Reply-To: <20070425212339.f16f9d7f.akpm@linux-foundation.org>
On Wed, Apr 25, 2007 at 09:23:39PM -0700, Andrew Morton wrote:
> On Thu, 26 Apr 2007 00:20:19 -0400 Dave Jones <davej@redhat.com> wrote:
>
> > On Wed, Apr 25, 2007 at 07:21:58PM -0700, Andrew Morton wrote:
> > > On Mon, 23 Apr 2007 14:51:29 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > >
> > > > {
> > > > struct agp_bridge_data *bridge = pci_get_drvdata(pdev);
> > > >
> > > > + pci_dev_put(bridge->dev);
> > > > agp_remove_bridge(bridge);
> > > > agp_put_bridge(bridge);
> > > > + pci_dev_put(serverworks_private.svrwrks_dev)
> > > > + serverworks_private.svrwrks_dev = NULL;
> > >
> > > err, guys?
> >
> > ? One put for the agp bridge, one for the host bridge.
> > What am I missing?
> >
>
> a semicolon.
Yow. I thought I build tested that.
I'll regenerate the git tree tomorrow. Same goes for the cpufreq
tree with the acpi fixup.
Thanks.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-04-26 4:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 13:51 [PATCH] sworks-agp: Switch to PCI ref counting APIs Alan Cox
2007-04-26 2:21 ` Andrew Morton
2007-04-26 4:20 ` Dave Jones
2007-04-26 4:23 ` Andrew Morton
2007-04-26 4:26 ` Dave Jones [this message]
2007-04-26 13:21 ` Alan Cox
2007-04-26 13:13 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070426042617.GC11278@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox