Re: [PATCH 1/3] ia64: convert to use clocksource code

Daniel Walker
2007-04-26T21:09:23Z

On Thu, 2007-04-26 at 16:26 -0400, Peter Keilty wrote:

> + .mask = (1LL << 40) - 1,
> + .mult = 0, /*to be caluclated*/
> + .shift = 16,
> + .is_continuous = 1,
> };

You should use CLOCKSOURCE_MASK() here ..

>
> diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
> index daa4940..a20b4d6 100644
> --- a/include/linux/clocksource.h
> +++ b/include/linux/clocksource.h
> @@ -61,6 +61,9 @@ struct clocksource {
> u32 shift;
> unsigned long flags;
> cycle_t (*vread)(void);
> +#ifdef CONFIG_IA64
> + void *fsys_mmio_ptr; /* used by fsyscall asm code */
> +#endif

Could you explain in detail why this is needed?

Daniel