Re: [PATCH 1/5] Power Management: use mutexes instead of semaphores

Andrew Morton
2007-05-04T07:18:56Z

On Fri, 4 May 2007 09:08:40 +0200 Matthias Kaehlcke <matthias.kaehlcke@gmail.com> wrote:

> > I note that none of these patches added a #include <linux/mutex.h>. Each C
> > file which uses mutexes should do that, rather than relying upon accidental
> > nested includes. I hope you're checking for that.
>
> initially i added the include line (i think at least one patch still
> contains it), but then i realized that in most cases the original code
> doesn't include semaphore.h and i (mis-)interpreted that it should be
> handled the same way (relying upon nested includes) for mutexes.
>
> do you want me to send you a version of the patches containing the
> include?

erm, is OK, I'll make the changes.