Re: [PATCH 1/5] Power Management: use mutexes instead of semaphores

Andrew Morton
2007-05-04T05:54:39Z

On Fri, 27 Apr 2007 10:43:22 +0200 Matthias Kaehlcke <matthias.kaehlcke@gmail.com> wrote:

> the Power Management code uses semaphores as mutexes. use the mutex
> API instead of the (binary) semaphores

I know it's a little thing, but given a choice between

a) changelogs which use capital letters and fullstops and

b) changelogs which do not,

I think a) gives a better result.

I note that none of these patches added a #include <linux/mutex.h>. Each C
file which uses mutexes should do that, rather than relying upon accidental
nested includes. I hope you're checking for that.