* linux-2.6.21-rc7-mm2 fails to compile
@ 2007-04-27 0:00 William Heimbigner
2007-04-27 0:54 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: William Heimbigner @ 2007-04-27 0:00 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton
Output leading up to the error:
CC drivers/macintosh/macio-adb.o
LD drivers/macintosh/built-in.o
CC [M] drivers/macintosh/apm_emu.o
CC [M] drivers/macintosh/therm_windtunnel.o
drivers/macintosh/therm_windtunnel.c: In function 'therm_of_remove':
drivers/macintosh/therm_windtunnel.c:462: error: void value not ignored as it
ought to be
drivers/macintosh/therm_windtunnel.c:463: warning: control reaches end of
non-void function
make[2]: *** [drivers/macintosh/therm_windtunnel.o] Error 1
make[1]: *** [drivers/macintosh] Error 2
make: *** [drivers] Error 2
This is on an iMac G3 powerpc.
William Heimbigner
icxcnika@mar.tar.cc
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-2.6.21-rc7-mm2 fails to compile
2007-04-27 0:00 linux-2.6.21-rc7-mm2 fails to compile William Heimbigner
@ 2007-04-27 0:54 ` Andrew Morton
2007-04-27 1:17 ` Randy Dunlap
2007-04-27 7:37 ` Jean Delvare
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Morton @ 2007-04-27 0:54 UTC (permalink / raw)
To: William Heimbigner; +Cc: linux-kernel, Jean Delvare, Benjamin Herrenschmidt
On Fri, 27 Apr 2007 00:00:15 +0000 (GMT) William Heimbigner <icxcnika@mar.tar.cc> wrote:
> Output leading up to the error:
>
> CC drivers/macintosh/macio-adb.o
> LD drivers/macintosh/built-in.o
> CC [M] drivers/macintosh/apm_emu.o
> CC [M] drivers/macintosh/therm_windtunnel.o
> drivers/macintosh/therm_windtunnel.c: In function 'therm_of_remove':
> drivers/macintosh/therm_windtunnel.c:462: error: void value not ignored as it
> ought to be
> drivers/macintosh/therm_windtunnel.c:463: warning: control reaches end of
> non-void function
> make[2]: *** [drivers/macintosh/therm_windtunnel.o] Error 1
> make[1]: *** [drivers/macintosh] Error 2
> make: *** [drivers] Error 2
>
> This is on an iMac G3 powerpc.
i2c_del_driver() was changed to reutrn void in the i2c tree.
--- a/drivers/macintosh/therm_windtunnel.c~fix-jdelvare-i2c-i2c-del-driver-returns-void-on-powerpc
+++ a/drivers/macintosh/therm_windtunnel.c
@@ -459,7 +459,8 @@ therm_of_probe( struct of_device *dev, c
static int
therm_of_remove( struct of_device *dev )
{
- return i2c_del_driver( &g4fan_driver );
+ i2c_del_driver( &g4fan_driver );
+ return 0;
}
static struct of_device_id therm_of_match[] = {{
_
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-2.6.21-rc7-mm2 fails to compile
2007-04-27 0:54 ` Andrew Morton
@ 2007-04-27 1:17 ` Randy Dunlap
2007-04-27 7:37 ` Jean Delvare
1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2007-04-27 1:17 UTC (permalink / raw)
To: Andrew Morton
Cc: William Heimbigner, linux-kernel, Jean Delvare,
Benjamin Herrenschmidt
On Thu, 26 Apr 2007 17:54:20 -0700 Andrew Morton wrote:
> On Fri, 27 Apr 2007 00:00:15 +0000 (GMT) William Heimbigner <icxcnika@mar.tar.cc> wrote:
>
> > Output leading up to the error:
> >
> > CC drivers/macintosh/macio-adb.o
> > LD drivers/macintosh/built-in.o
> > CC [M] drivers/macintosh/apm_emu.o
> > CC [M] drivers/macintosh/therm_windtunnel.o
> > drivers/macintosh/therm_windtunnel.c: In function 'therm_of_remove':
> > drivers/macintosh/therm_windtunnel.c:462: error: void value not ignored as it
> > ought to be
> > drivers/macintosh/therm_windtunnel.c:463: warning: control reaches end of
> > non-void function
> > make[2]: *** [drivers/macintosh/therm_windtunnel.o] Error 1
> > make[1]: *** [drivers/macintosh] Error 2
> > make: *** [drivers] Error 2
> >
> > This is on an iMac G3 powerpc.
>
> i2c_del_driver() was changed to reutrn void in the i2c tree.
>
> --- a/drivers/macintosh/therm_windtunnel.c~fix-jdelvare-i2c-i2c-del-driver-returns-void-on-powerpc
> +++ a/drivers/macintosh/therm_windtunnel.c
> @@ -459,7 +459,8 @@ therm_of_probe( struct of_device *dev, c
> static int
> therm_of_remove( struct of_device *dev )
> {
> - return i2c_del_driver( &g4fan_driver );
> + i2c_del_driver( &g4fan_driver );
> + return 0;
> }
>
> static struct of_device_id therm_of_match[] = {{
This will fail on the "ugly parentheses" test... :)
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-2.6.21-rc7-mm2 fails to compile
2007-04-27 0:54 ` Andrew Morton
2007-04-27 1:17 ` Randy Dunlap
@ 2007-04-27 7:37 ` Jean Delvare
1 sibling, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2007-04-27 7:37 UTC (permalink / raw)
To: Andrew Morton; +Cc: William Heimbigner, linux-kernel, Benjamin Herrenschmidt
On Thu, 26 Apr 2007 17:54:20 -0700, Andrew Morton wrote:
> On Fri, 27 Apr 2007 00:00:15 +0000 (GMT) William Heimbigner <icxcnika@mar.tar.cc> wrote:
>
> > Output leading up to the error:
> >
> > CC drivers/macintosh/macio-adb.o
> > LD drivers/macintosh/built-in.o
> > CC [M] drivers/macintosh/apm_emu.o
> > CC [M] drivers/macintosh/therm_windtunnel.o
> > drivers/macintosh/therm_windtunnel.c: In function 'therm_of_remove':
> > drivers/macintosh/therm_windtunnel.c:462: error: void value not ignored as it
> > ought to be
> > drivers/macintosh/therm_windtunnel.c:463: warning: control reaches end of
> > non-void function
> > make[2]: *** [drivers/macintosh/therm_windtunnel.o] Error 1
> > make[1]: *** [drivers/macintosh] Error 2
> > make: *** [drivers] Error 2
> >
> > This is on an iMac G3 powerpc.
>
> i2c_del_driver() was changed to reutrn void in the i2c tree.
>
> --- a/drivers/macintosh/therm_windtunnel.c~fix-jdelvare-i2c-i2c-del-driver-returns-void-on-powerpc
> +++ a/drivers/macintosh/therm_windtunnel.c
> @@ -459,7 +459,8 @@ therm_of_probe( struct of_device *dev, c
> static int
> therm_of_remove( struct of_device *dev )
> {
> - return i2c_del_driver( &g4fan_driver );
> + i2c_del_driver( &g4fan_driver );
> + return 0;
> }
>
> static struct of_device_id therm_of_match[] = {{
> _
Sorry for the trouble and thanks for reporting. I've merged the fix
above in the original patch now.
--
Jean Delvare
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-04-27 7:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-27 0:00 linux-2.6.21-rc7-mm2 fails to compile William Heimbigner
2007-04-27 0:54 ` Andrew Morton
2007-04-27 1:17 ` Randy Dunlap
2007-04-27 7:37 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox