Re: [patch 18/38] Improved oops output.

Martin Schwidefsky
2007-04-27T15:24:10Z

On Fri, 2007-04-27 at 15:25 +0100, Christoph Hellwig wrote:
> On Fri, Apr 27, 2007 at 04:05:21PM +0200, Martin Schwidefsky wrote:
> > From: Martin Schwidefsky <schwidefsky@de.ibm.com>
> >
> > This patch adds two improvements to the oops output. First it adds an
> > additional line after the PSW which decodes the different fields of it.
> > Second a disassembler is added that decodes the instructions surrounding
> > the faulting PSW. The output of a test oops now looks like this:
>
> So we're growing in-kernel disassemblers now? :)
>
> I wonder whether this is really worth it, but at least your handwritten
> one is much nicer than the copy & paste from gdb in the kdb patches.

The disassembler uses about 8K of memory and it really helps in
debugging. For me it is worth the cost.