From: Sam Ravnborg <sam@ravnborg.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: jdike@addtoit.com, linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [patch] uml: fix cmpxchg warnings in -mm
Date: Fri, 27 Apr 2007 19:27:48 +0200 [thread overview]
Message-ID: <20070427172748.GC1046@uranus.ravnborg.org> (raw)
In-Reply-To: <E1HhT90-0001dW-00@dorka.pomaz.szeredi.hu>
On Fri, Apr 27, 2007 at 06:18:02PM +0200, Miklos Szeredi wrote:
>
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> I get lot's of these on i386:
>
> In file included from include/asm/atomic.h:10,
> from include/linux/file.h:9,
> from mm/fadvise.c:12:
> include/asm/arch/atomic.h: In function ‘atomic_add_unless’:
> include/asm/arch/atomic.h:240: warning: implicit declaration of function ‘cmpxchg’
> [...]
>
> The problem seems to be that <asm-i386/atomic.h> assumes that
> <asm/processor.h> pulls in <asm/system.h>.
Then atomic.h should include system.h and not rely on someone else doing it.
Yes - then system.h may be included twice but that's ok.
Sam
next prev parent reply other threads:[~2007-04-27 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 16:18 [patch] uml: fix cmpxchg warnings in -mm Miklos Szeredi
2007-04-27 16:19 ` [patch] uml: remove #warnings Miklos Szeredi
2007-04-27 17:27 ` Sam Ravnborg [this message]
2007-04-27 17:35 ` [patch] uml: fix cmpxchg warnings in -mm Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070427172748.GC1046@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox