From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757156AbXD0T2P (ORCPT ); Fri, 27 Apr 2007 15:28:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757157AbXD0T2P (ORCPT ); Fri, 27 Apr 2007 15:28:15 -0400 Received: from colin.muc.de ([193.149.48.1]:2159 "EHLO mail.muc.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757155AbXD0T2N (ORCPT ); Fri, 27 Apr 2007 15:28:13 -0400 Date: 27 Apr 2007 21:28:11 +0200 Date: Fri, 27 Apr 2007 21:28:11 +0200 From: Andi Kleen To: Tim Hockin Cc: vojtech@suse.cz, linux-kernel@vger.kernel.org, akpm@google.com Subject: Re: [PATCH] x86_64: dynamic MCE poll interval Message-ID: <20070427192811.GA37201@muc.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > - printk(KERN_INFO "Machine check events logged\n"); > + if ((now - last_print) >= check_interval*HZ) { Shouldn't this use time_after() to handle wrapping? -Andi