From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Roland Dreier <rdreier@cisco.com>, Dave Jones <davej@redhat.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: checkpatch, a patch checking script.
Date: Sat, 28 Apr 2007 01:16:25 -0700 [thread overview]
Message-ID: <20070428011625.0f048426.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0704280956190.506@yvahk01.tjqt.qr>
On Sat, 28 Apr 2007 10:01:00 +0200 (MEST) Jan Engelhardt <jengelh@linux01.gwdg.de> wrote:
> And since when is uint32_t wrong? What makes u32 or __u32 better?
There's not much to be said in favour of u32, really. Except it's shorter
and I can never remember where the underscore goes in uint_32t.
If kernel used u_int32_t globally then the world would probably be a better
place. But using just the one name has its advantages from a consistency
POV.
box:/usr/src/linux-2.6.21> grep -r '[ \(]u32' . | wc -l
39599
box:/usr/src/linux-2.6.21> grep -r '[ \(]uint32_t' . | wc -l
5132
CodingStyle permits either variant, fwiw.
next prev parent reply other threads:[~2007-04-28 8:16 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 14:11 [PATCH 0/9] Kconfig: cleanup s390 v2 Martin Schwidefsky
2007-04-23 16:52 ` Arnd Bergmann
2007-04-23 17:45 ` Andrew Morton
2007-04-24 7:52 ` Martin Schwidefsky
2007-04-25 18:21 ` Randy Dunlap
2007-04-25 21:30 ` Andrew Morton
2007-04-26 0:24 ` Andrew Morton
2007-04-26 0:32 ` Arnd Bergmann
2007-04-26 1:06 ` Andrew Morton
2007-04-27 14:21 ` patch style checks Andy Whitcroft
2007-04-27 15:44 ` jschopp
2007-04-26 1:39 ` [PATCH 0/9] Kconfig: cleanup s390 v2 Anton Vorontsov
2007-04-26 8:30 ` Andrew Morton
2007-04-26 20:36 ` Randy Dunlap
2007-04-26 0:39 ` Dave Jones
2007-04-26 2:38 ` Randy Dunlap
2007-04-26 3:02 ` Andrew Morton
2007-04-26 4:24 ` Dave Jones
2007-04-28 3:08 ` checkpatch, a patch checking script Dave Jones
2007-04-28 3:36 ` Roland Dreier
2007-04-28 3:47 ` Adrian Bunk
2007-04-30 0:43 ` Randy Dunlap
2007-04-28 5:18 ` Andrew Morton
2007-04-28 5:50 ` Roland Dreier
2007-04-28 10:52 ` Andi Kleen
2007-04-28 5:58 ` Roland Dreier
2007-04-28 8:01 ` Jan Engelhardt
2007-04-28 8:16 ` Andrew Morton [this message]
2007-04-28 10:53 ` Jan Engelhardt
2007-04-29 23:35 ` Randy Dunlap
2007-04-28 10:48 ` Andi Kleen
2007-04-28 10:02 ` Andrew Morton
2007-04-28 10:15 ` Alan Cox
2007-04-28 11:18 ` Andi Kleen
2007-04-28 11:32 ` Alan Cox
2007-04-28 17:06 ` Dave Jones
2007-04-28 18:11 ` Jeff Garzik
2007-04-30 0:59 ` Randy Dunlap
2007-04-28 16:11 ` Matt Mackall
2007-04-28 17:11 ` Dave Jones
2007-04-28 17:21 ` Matt Mackall
2007-04-29 23:37 ` Randy Dunlap
2007-04-30 0:09 ` Matt Mackall
2007-04-30 0:18 ` Randy Dunlap
2007-04-30 1:59 ` Matt Mackall
2007-04-30 23:59 ` Randy Dunlap
2007-05-02 14:28 ` Geert Uytterhoeven
2007-05-02 15:29 ` Christoph Hellwig
2007-05-02 15:32 ` Geert Uytterhoeven
2007-05-02 19:41 ` Andrew Morton
2007-05-02 19:55 ` Geert Uytterhoeven
2007-05-02 20:29 ` Andrew Morton
2007-05-02 19:08 ` Jan Engelhardt
2007-05-02 19:05 ` Jan Engelhardt
2007-05-03 7:32 ` Sébastien Dugué
2007-05-03 9:27 ` Geert Uytterhoeven
2007-04-26 13:02 ` [PATCH 0/9] Kconfig: cleanup s390 v2 Andy Whitcroft
2007-05-09 11:21 ` Martin Schwidefsky
2007-05-09 16:35 ` Andrew Morton
2007-05-10 7:25 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070428011625.0f048426.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox