From: Len Brown <lenb@kernel.org>
To: Steven Whitehouse <swhiteho@redhat.com>, Andi Kleen <ak@suse.de>,
Shai Fultheim <shai@scalex86.org>,
Ravikiran Thirumalai <kiran@scalex86.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: ACPI build problem (2.6.21 CONFIG_X86_64_ACPI_NUMA)
Date: Sat, 28 Apr 2007 01:59:46 -0400 [thread overview]
Message-ID: <200704280159.46337.lenb@kernel.org> (raw)
In-Reply-To: <1177593963.5462.12.camel@quoit.chygwyn.com>
On Thursday 26 April 2007 09:26, you wrote:
> Hi,
>
> With the attached kernel config I get the following build errors. They
> go away if I turn power management support on:
>
> drivers/built-in.o: In function `acpi_bus_generate_event':
> /home/steve/gfs2-2.6-fixes.git/drivers/acpi/bus.c:294: undefined
> reference to `event_is_open'
> drivers/built-in.o: In function `acpi_bus_get_power':
> /home/steve/gfs2-2.6-fixes.git/drivers/acpi/bus.c:160: undefined
> reference to `acpi_power_get_inferred_state'
> drivers/built-in.o: In function `acpi_bus_set_power':
> /home/steve/gfs2-2.6-fixes.git/drivers/acpi/bus.c:230: undefined
> reference to `acpi_power_transition'
> /home/steve/gfs2-2.6-fixes.git/drivers/acpi/bus.c:252: undefined
> reference to `acpi_power_transition'
> make: *** [.tmp_vmlinux1] Error 1
>
> This is with my gfs2 tree which is basically 2.6.21 plus a few patches
> which only affect gfs2/dlm, so its upstream to all intents and purposes.
CONFIG_ACPI depends on CONFIG_PM, yet this build fails because you have
CONFIG_ACPI=y and CONFIG_PM=n
Unfortunately kconfig doesn't trace dependencies when "select" is used,
making select sort of evil. Ie. select can't target anything which
itself has dependencies.
In 2.6.15, b0bd35e622ffbda2c01dc67a0381c6a18817a29a added the select below,
and subsequently ACPI became dependent on PM, which broke your build.
Technically, this could have broken your build in other ways too
since ACPI already had other dependencies.
+# Dummy CONFIG option to select ACPI_NUMA from drivers/acpi/Kconfig.
+
+config X86_64_ACPI_NUMA
+ bool "ACPI NUMA detection"
+ depends on NUMA
+ select ACPI
+ select ACPI_NUMA
+ default y
+ help
+ Enable ACPI SRAT based node topology detection.
If you de-select CONFIG_X86_64_ACPI_NUMA then the select goes away
and kconfig should work properly.
It isn't immediately clear to me how the NUMA Kconfig patch is a step
forward, but perhaps the authors can comment.
-Len
next parent reply other threads:[~2007-04-28 6:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1177593963.5462.12.camel@quoit.chygwyn.com>
2007-04-28 5:59 ` Len Brown [this message]
2007-04-30 18:28 ` ACPI build problem (2.6.21 CONFIG_X86_64_ACPI_NUMA) Ravikiran G Thirumalai
2007-05-10 8:04 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704280159.46337.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=ak@suse.de \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shai@scalex86.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox