From: Peter Stuge <stuge-linux-pcmcia@cdy.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Aeschbacher, Fabrice" <Fabrice.Aeschbacher@siemens.com>,
linux-pcmcia@lists.infradead.org,
lkml <linux-kernel@vger.kernel.org>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
Date: Sat, 28 Apr 2007 04:09:50 +0200 [thread overview]
Message-ID: <20070428020950.15491.qmail@cdy.org> (raw)
In-Reply-To: <20070427190143.d597dd38.akpm@linux-foundation.org>
On Fri, Apr 27, 2007 at 07:01:43PM -0700, Andrew Morton wrote:
> This one-liner is turning into a fiasco.
> diff -puN drivers/ide/legacy/ide-cs.c~ide-cs-recognize-2gb-compactflash-from-transcend drivers/ide/legacy/ide-cs.c
> --- a/drivers/ide/legacy/ide-cs.c~ide-cs-recognize-2gb-compactflash-from-transcend
> +++ a/drivers/ide/legacy/ide-cs.c
> @@ -401,6 +401,8 @@ static struct pcmcia_device_id ide_ids[]
> PCMCIA_DEVICE_PROD_ID12("TOSHIBA", "MK2001MPL", 0xb4585a1a, 0x3489e003),
> PCMCIA_DEVICE_PROD_ID1("TRANSCEND 512M ", 0xd0909443),
> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80", 0x709b1bf1, 0x2a54d4b1),
> + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1, 0xf54a91c8),
> + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1, 0x969aa4f2),
> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120", 0x709b1bf1, 0xf54a91c8),
> PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994, 0x3e232852),
> PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c, 0x212bb918),
> _
>
>
> Is this really supposed to add a TS2GCF120 entry with the same IDs
> as TS4GCF120?
That's probably a copy and paste error. 0x969aa4f2 is the correct ID.
> And pata_pcmcia-recognize-2gb-compactflash-from-transcend.patch:
This one is all right so for what it's worth, it gets:
Acked-by: Peter Stuge <peter@stuge.se>
//Peter
next prev parent reply other threads:[~2007-04-28 2:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-22 19:26 Fw: [PATCH][RFC] PCMCIA support for 8xx using platform devices Vitaly Bordug
2007-04-22 21:49 ` Arnd Bergmann
2007-04-23 6:14 ` Vitaly Bordug
2007-04-23 7:59 ` Christoph Hellwig
2007-04-23 19:55 ` Vitaly Bordug
2007-04-23 21:12 ` Segher Boessenkool
2007-04-25 9:27 ` [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend Aeschbacher, Fabrice
2007-04-25 20:39 ` Peter Stuge
2007-04-26 0:15 ` Andrew Morton
2007-04-26 9:21 ` Aeschbacher, Fabrice
2007-04-28 2:01 ` Andrew Morton
2007-04-28 2:09 ` Peter Stuge [this message]
2007-04-26 9:49 ` [PATCH] pata_pcmcia: " Aeschbacher, Fabrice
2007-04-23 19:07 ` Fw: [PATCH][RFC] PCMCIA support for 8xx using platform devices Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070428020950.15491.qmail@cdy.org \
--to=stuge-linux-pcmcia@cdy.org \
--cc=Fabrice.Aeschbacher@siemens.com \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox