From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] h8300 generic irq
Date: Sat, 28 Apr 2007 09:42:25 +0100 [thread overview]
Message-ID: <20070428084225.GA22480@infradead.org> (raw)
In-Reply-To: <20070427190935.68606a3a.akpm@linux-foundation.org>
On Fri, Apr 27, 2007 at 07:09:35PM -0700, Andrew Morton wrote:
> > +/*
> > + * h8300 interrupt controler implementation
> > + */
> > +struct irq_chip h8300irq_chip = {
> > + .name = "H8300-INTC",
> > + .startup = h8300_startup_irq,
> > + .shutdown = h8300_shutdown_irq,
> > + .enable = h8300_enable_irq,
> > + .disable = h8300_disable_irq,
> > + .ack = NULL,
> > + .end = h8300_end_irq,
> > +};
>
> I think this could have static scope.
Pluse there's not need to set .ack to NULL explicitly.
next prev parent reply other threads:[~2007-04-28 8:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 8:34 [PATCH] h8300 generic irq Yoshinori Sato
2007-04-28 2:09 ` Andrew Morton
2007-04-28 8:42 ` Christoph Hellwig [this message]
2007-04-30 15:15 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070428084225.GA22480@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox