From: William Lee Irwin III <wli@holomorphy.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Akinobu Mita <akinobu.mita@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hugetlbfs: fix error path in module_init
Date: Sat, 28 Apr 2007 07:46:26 -0700 [thread overview]
Message-ID: <20070428144626.GW19966@holomorphy.com> (raw)
In-Reply-To: <b6fcc0a0704280044i3ff820b6w343bd73c7a08f708@mail.gmail.com>
On Sat, Apr 28, 2007 at 11:44:43AM +0400, Alexey Dobriyan wrote:
> On 4/28/07, Akinobu Mita <akinobu.mita@gmail.com> wrote:
> >init_hugetlbfs_fs() needs to unregister hugetlbfs
> >when kern_mount() returns error.
> HUGETLBFS is bool, so __init function should panic more and
> __exit function should be removed. Or someone is planning
> making it tristate?
It'd be nice for it to be normal enough to go tristate, but there isn't
going to be any effort expended directly to that end. Might as well
remove the exit function. Probably mostly pointless to try to avoid
panicking, but I'd not bother with new panics as a simplification just
because panicking is somewhat rude.
- wli
next prev parent reply other threads:[~2007-04-28 14:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-28 7:19 [PATCH] hugetlbfs: fix error path in module_init Akinobu Mita
2007-04-28 7:44 ` Alexey Dobriyan
2007-04-28 10:58 ` Akinobu Mita
2007-04-28 14:46 ` William Lee Irwin III [this message]
2007-04-28 14:50 ` William Lee Irwin III
2007-04-28 16:18 ` Akinobu Mita
2007-04-28 16:29 ` [PATCH] hugetlbfs: add NULL check in hugetlb_zero_setup() Akinobu Mita
2007-04-28 18:15 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070428144626.GW19966@holomorphy.com \
--to=wli@holomorphy.com \
--cc=adobriyan@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox