* [PATCH] Propagate errors from find in scripts/gen_initramfs_list.sh
@ 2007-04-30 5:34 Michael Ellerman
2007-05-01 21:05 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Michael Ellerman @ 2007-04-30 5:34 UTC (permalink / raw)
To: Andrew Morton; +Cc: azarah, sam, linux-kernel
If the find(1) in scripts/gen_initramfs_list.sh generates any errors, it
will cause gen_initramfs_list.sh to fail (because of "set -e"), however
the errors from find are not printed to the user. This is rather confusing:
~/src/powerpc$ make O=~/build/powerpc-cell32/
make[2]: *** [usr/initramfs_data.cpio.gz] Error 1
make[1]: *** [usr] Error 2
make[1]: *** Waiting for unfinished jobs....
make[1]: *** wait: No child processes. Stop.
make: *** [_all] Error 2
It is much easier to work out what the problem is if we let the errors
from find hit the console, eg:
~/src/powerpc$ make O=~/build/powerpc-cell32/
find: /home/michael/initramfs-source/home: Permission denied
find: /home/michael/initramfs-source/lost+found: Permission denied
find: /home/michael/initramfs-source/opt: Permission denied
find: /home/michael/initramfs-source/root: Permission denied
make[2]: *** [usr/initramfs_data.cpio.gz] Error 1
make[1]: *** [usr] Error 2
make[1]: *** Waiting for unfinished jobs....
make[1]: *** wait: No child processes. Stop.
make: *** [_all] Error 2
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
scripts/gen_initramfs_list.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: powerpc/scripts/gen_initramfs_list.sh
===================================================================
--- powerpc.orig/scripts/gen_initramfs_list.sh
+++ powerpc/scripts/gen_initramfs_list.sh
@@ -171,7 +171,7 @@ dir_filelist() {
${dep_list}header "$1"
srcdir=$(echo "$1" | sed -e 's://*:/:g')
- dirlist=$(find "${srcdir}" -printf "%p %m %U %G\n" 2>/dev/null)
+ dirlist=$(find "${srcdir}" -printf "%p %m %U %G\n")
# If $dirlist is only one line, then the directory is empty
if [ "$(echo "${dirlist}" | wc -l)" -gt 1 ]; then
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Propagate errors from find in scripts/gen_initramfs_list.sh
2007-04-30 5:34 [PATCH] Propagate errors from find in scripts/gen_initramfs_list.sh Michael Ellerman
@ 2007-05-01 21:05 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2007-05-01 21:05 UTC (permalink / raw)
To: Michael Ellerman; +Cc: Andrew Morton, azarah, linux-kernel
On Mon, Apr 30, 2007 at 03:34:15PM +1000, Michael Ellerman wrote:
> If the find(1) in scripts/gen_initramfs_list.sh generates any errors, it
> will cause gen_initramfs_list.sh to fail (because of "set -e"), however
> the errors from find are not printed to the user. This is rather confusing:
Agree - patch applied.
Sam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-01 21:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-30 5:34 [PATCH] Propagate errors from find in scripts/gen_initramfs_list.sh Michael Ellerman
2007-05-01 21:05 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox