public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] pm: include EIO from errno-base.h
Date: Mon, 30 Apr 2007 07:51:06 -0700	[thread overview]
Message-ID: <200704300751.07078.david-b@pacbell.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0704291700220.1822@chino.kir.corp.google.com>

On Monday 30 April 2007, David Rientjes wrote:
> call_platform_enable_wakeup() uses EIO, so it needs to be defined.
> 
> Cc: David Brownell <dbrownell@users.sourceforge.net>
> Signed-off-by: David Rientjes <rientjes@google.com>

Actually, in that PM-is-disabled case returning zero (success)
rather than -EIO would have been the backwards-compatible
approach ... the hook not being there shouldn't be an error.
And returning zero wouldn't require this #include either...

- Dave


> ---
>  include/linux/pm.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -25,6 +25,7 @@
>  
>  #include <linux/list.h>
>  #include <asm/atomic.h>
> +#include <asm/errno.h>
>  
>  /*
>   * Power management requests... these are passed to pm_send_all() and friends.
> 



  reply	other threads:[~2007-04-30 14:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-30 14:34 [patch] pm: include EIO from errno-base.h David Rientjes
2007-04-30 14:51 ` David Brownell [this message]
2007-04-30 19:15   ` David Rientjes
2007-04-30 21:02     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704300751.07078.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox