[patch] pm: include EIO from errno-base.h

[patch] pm: include EIO from errno-base.h

[David Rientjes]

call_platform_enable_wakeup() uses EIO, so it needs to be defined.

Cc: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: David Rientjes <rientjes@google.com>
---
 include/linux/pm.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/pm.h b/include/linux/pm.h
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -25,6 +25,7 @@
 
 #include <linux/list.h>
 #include <asm/atomic.h>
+#include <asm/errno.h>
 
 /*
  * Power management requests... these are passed to pm_send_all() and friends.

Re: [patch] pm: include EIO from errno-base.h

[David Brownell]

On Monday 30 April 2007, David Rientjes wrote:
> call_platform_enable_wakeup() uses EIO, so it needs to be defined.
> 
> Cc: David Brownell <dbrownell@users.sourceforge.net>
> Signed-off-by: David Rientjes <rientjes@google.com>

Actually, in that PM-is-disabled case returning zero (success)
rather than -EIO would have been the backwards-compatible
approach ... the hook not being there shouldn't be an error.
And returning zero wouldn't require this #include either...

- Dave


> ---
>  include/linux/pm.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -25,6 +25,7 @@
>  
>  #include <linux/list.h>
>  #include <asm/atomic.h>
> +#include <asm/errno.h>
>  
>  /*
>   * Power management requests... these are passed to pm_send_all() and friends.
> 

Re: [patch] pm: include EIO from errno-base.h

[David Rientjes]

For backwards compatibility, call_platform_enable_wakeup() can return 0 
instead of -EIO since we aren't guaranteed to have errno defined.

Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: David Rientjes <rientjes@google.com>
---
 include/linux/pm.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/pm.h b/include/linux/pm.h
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -328,7 +328,7 @@ static inline void dpm_runtime_resume(struct device * dev)
 
 static inline int call_platform_enable_wakeup(struct device *dev, int is_on)
 {
-	return -EIO;
+	return 0;
 }
 
 #endif

Re: [patch] pm: include EIO from errno-base.h

[Randy Dunlap]

On Mon, 30 Apr 2007 12:15:57 -0700 (PDT) David Rientjes wrote:

> For backwards compatibility, call_platform_enable_wakeup() can return 0 
> instead of -EIO since we aren't guaranteed to have errno defined.
> 
> Cc: David Brownell <david-b@pacbell.net>
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
>  include/linux/pm.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -328,7 +328,7 @@ static inline void dpm_runtime_resume(struct device * dev)
>  
>  static inline int call_platform_enable_wakeup(struct device *dev, int is_on)
>  {
> -	return -EIO;
> +	return 0;
>  }
>  
>  #endif


Andrew,
Can you fasttrack this one?  otherwise allnoconfig fails.  :(

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***