Re: [PATCH] mm/memory.c: remove warning from an uninitialized spinlock. was: Re: 2.6.21-rc7-mm2

Steven Rostedt
2007-11-07T19:20:57Z

>
> Introduce a macro for suppressing gcc from generating a warning about a
> probable uninitialized state of a variable.
>
> Example:
>
> - spinlock_t *ptl;
> + spinlock_t *uninitialized_var(ptl);
>
> Not a happy solution, but those warnings are obnoxious.
>
> - Using the usual pointlessly-set-it-to-zero approach wastes several
> bytes of text.
>
> - Using a macro means we can (hopefully) do something else if gcc changes
> cause the `x = x' hack to stop working
>
> - Using a macro means that people who are worried about hiding true bugs
> can easily turn it off.
>
> Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

I just stumbled across this being in the kernel. Well, I'm finally glad
it made it in, even though it was suggested one year earlier ;-)

http://lkml.org/lkml/2006/5/11/50

-- Steve