public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>, David Chinner <dgc@sgi.com>,
	Zan Lynx <zlynx@acm.org>, Adrian Bunk <bunk@stusta.de>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [6/6] arrange for a guard page on cpu 0's IRQ stack (was: Re: [-mm patch] i386: enable 4k stacks by default)
Date: Mon, 30 Apr 2007 10:47:30 -0700	[thread overview]
Message-ID: <20070430174730.GI19966@holomorphy.com> (raw)
In-Reply-To: <20070430173819.GC19966@holomorphy.com>

On Mon, Apr 30, 2007 at 10:38:19AM -0700, William Lee Irwin III wrote:
> Here's what I did for i386 for someone concerned about blowing the stack.

vmap() cpu 0's IRQ stack to ensure a guard page for it.

Signed-off-by: William Irwin <wli@holomorphy.com>


Index: stack-paranoia/arch/i386/kernel/irq.c
===================================================================
--- stack-paranoia.orig/arch/i386/kernel/irq.c	2007-04-30 10:36:14.553987258 -0700
+++ stack-paranoia/arch/i386/kernel/irq.c	2007-04-30 10:37:09.909141769 -0700
@@ -17,6 +17,7 @@
 #include <linux/notifier.h>
 #include <linux/cpu.h>
 #include <linux/delay.h>
+#include <linux/mm.h>
 #include <linux/bootmem.h>
 
 #include <asm/apic.h>
@@ -156,6 +157,41 @@
 static DEFINE_PER_CPU(char *, hardirq_stack);
 
 #ifdef CONFIG_VMALLOC_STACK
+static void * __init irq_remap_stack(void *stack)
+{
+	int i;
+	struct page *pages[THREAD_SIZE/PAGE_SIZE];
+
+	for (i = 0; i < ARRAY_SIZE(pages); ++i)
+		pages[i] =  virt_to_page(stack + PAGE_SIZE*i);
+	return vmap(pages, THREAD_SIZE/PAGE_SIZE, VM_IOREMAP, PAGE_KERNEL);
+}
+
+static int __init irq_guard_cpu0(void)
+{
+	unsigned long flags;
+	void *tmp;
+
+	tmp = irq_remap_stack(per_cpu(softirq_stack, 0));
+	if (!tmp)
+		return -ENOMEM;
+	else {
+		local_irq_save(flags);
+		per_cpu(softirq_stack, 0) = tmp;
+		local_irq_restore(flags);
+	}
+	tmp = irq_remap_stack(per_cpu(hardirq_stack, 0));
+	if (!tmp)
+		return -ENOMEM;
+	else {
+		local_irq_save(flags);
+		per_cpu(hardirq_stack, 0) = tmp;
+		local_irq_restore(flags);
+	}
+	return 0;
+}
+core_initcall(irq_guard_cpu0);
+
 static void * __init __alloc_irqstack(int cpu)
 {
 	int i;

  parent reply	other threads:[~2007-04-30 17:47 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-28 19:19 [-mm patch] i386: enable 4k stacks by default Adrian Bunk
2007-04-28 21:18 ` Zan Lynx
2007-04-30  3:58   ` David Chinner
2007-04-30  8:17     ` Alan Cox
2007-04-30 10:26       ` Andi Kleen
2007-04-30 10:48         ` Christoph Hellwig
2007-04-30 12:13           ` Andi Kleen
2007-04-30 17:38             ` William Lee Irwin III
2007-04-30 17:40               ` [1/6] make stack size configurable (was: Re: [-mm patch] i386: enable 4k stacks by default) William Lee Irwin III
2007-04-30 18:10                 ` Christoph Hellwig
2007-04-30 18:13                   ` William Lee Irwin III
2007-04-30 18:25                 ` Adrian Bunk
2007-04-30 18:32                   ` William Lee Irwin III
2007-04-30 17:43               ` [2/6] add config option to vmalloc stacks " William Lee Irwin III
2007-04-30 18:11                 ` Christoph Hellwig
2007-04-30 18:25                   ` Jan Engelhardt
2007-04-30 19:09                   ` William Lee Irwin III
2007-04-30 19:15                     ` Christoph Hellwig
2007-04-30 19:23                       ` Bill Irwin
2007-04-30 22:04                       ` Bill Irwin
2007-05-01 22:36                       ` Matt Mackall
2007-05-01 22:51                         ` Bill Irwin
2007-05-01 23:07                           ` Alan Cox
2007-05-01 23:23                             ` Bill Irwin
2007-05-01 23:15                           ` Matt Mackall
2007-05-01 23:27                             ` Bill Irwin
2007-05-04  5:35                 ` Joseph Fannin
2007-05-04  7:43                   ` Bill Irwin
2007-04-30 17:44               ` [3/6] make IRQ stacks independently configurable " William Lee Irwin III
2007-04-30 18:11                 ` Christoph Hellwig
2007-04-30 18:14                   ` William Lee Irwin III
2007-04-30 17:45               ` [4/6] go BUG on vmallocspace in __pa() " William Lee Irwin III
2007-04-30 18:52                 ` Andi Kleen
2007-04-30 18:58                   ` William Lee Irwin III
2007-04-30 19:20                   ` Alan Cox
2007-04-30 19:26                     ` Bill Irwin
2007-05-02 22:31                 ` [4/6] go BUG on vmallocspace in __pa() Jeremy Fitzhardinge
2007-05-02 22:48                   ` Bill Irwin
2007-04-30 17:46               ` [5/6] dynamically allocate IRQ stacks (was: Re: [-mm patch] i386: enable 4k stacks by default) William Lee Irwin III
2007-04-30 19:49                 ` Zwane Mwaikambo
2007-04-30 20:03                   ` Bill Irwin
2007-04-30 20:07                   ` Andi Kleen
2007-04-30 17:47               ` William Lee Irwin III [this message]
2007-04-30 18:22               ` [-mm patch] i386: enable 4k stacks by default Jan Engelhardt
2007-04-30 18:35                 ` William Lee Irwin III
2007-04-30 18:51               ` Andi Kleen
2007-04-30  8:55   ` Neil Brown
2007-04-30  8:59     ` Christoph Hellwig
2007-04-30 11:30       ` Jens Axboe
2007-04-30 23:24         ` Neil Brown
2007-05-01  8:01           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070430174730.GI19966@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=andi@firstfloor.org \
    --cc=bunk@stusta.de \
    --cc=dgc@sgi.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zlynx@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox