Re: [patch] megaraid: fix CONFIG_PROC_FS compile errors

[Andrew Morton <akpm@linux-foundation.org>]

On Mon, 30 Apr 2007 08:44:14 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:

> On Mon, 30 Apr 2007 07:35:00 -0700 (PDT) David Rientjes wrote:
> 
> > Only declare mega_proc_dir_entry() in CONFIG_PROC_FS.  We should call
> > mega_create_proc_entry() only in this configuration so make sure it's defined
> > if we call it.
> > 
> > Only define mega_adapinq() in CONFIG_PROC_FS.  mega_internal_dev_inquiry()
> > and mega_print_inquiry() were never declared without CONFIG_PROC_FS so
> > make sure we don't have prototypes for them if we aren't going to define
> > them.
> > 
> > Move the declaration of 'buf' in mega_remove_one() because we only use it
> > in the CONFIG_PROC_FS case.
> 
> Just noting the presence of:
>   http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc7/2.6.21-rc7-mm2/broken-out/megaraid-fix-warnings-when-config_proc_fs=n.patch
> 

That patch has been submitted fourteen times in the past year, and was
completely ignored each time.

> 
> Oh, and that SCSI patches need to go to the linux-scsi mailing list.
> 

There seem to be little point in doing that.