From: Bill Irwin <bill.irwin@oracle.com>
To: Zwane Mwaikambo <zwane@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Christoph Hellwig <hch@infradead.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, David Chinner <dgc@sgi.com>,
Zan Lynx <zlynx@acm.org>, Adrian Bunk <bunk@stusta.de>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [5/6] dynamically allocate IRQ stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)
Date: Mon, 30 Apr 2007 13:03:01 -0700 [thread overview]
Message-ID: <20070430200301.GE26598@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0704301247470.26601@montezuma.windriver.com>
On Mon, 30 Apr 2007, William Lee Irwin III wrote:
>> -static char softirq_stack[NR_CPUS * THREAD_SIZE]
>> - __attribute__((__aligned__(THREAD_SIZE)));
>> +static DEFINE_PER_CPU(char *, softirq_stack);
>> +static DEFINE_PER_CPU(char *, hardirq_stack);
>>
>> -static char hardirq_stack[NR_CPUS * THREAD_SIZE]
>> - __attribute__((__aligned__(THREAD_SIZE)));
>> +#ifdef CONFIG_VMALLOC_STACK
>> +static void * __init __alloc_irqstack(int cpu)
On Mon, Apr 30, 2007 at 12:49:04PM -0700, Zwane Mwaikambo wrote:
> How about just using DEFINE_PER_CPU and allowing the percpu code
> dynamically allocate.
The indirection was needed to vmalloc()/vmap() the IRQ stacks. It
should probably be decided explicitly whether vmalloc() of the IRQ
stacks is considered desirable for any mainline merge of these things.
This code is by no means sacred to me, so I have no particular
preference with respect to the suggested tradeoffs or reworks. Whatever
people want out of all this for mainline (even if nothing) is fine by me.
-- wli
next prev parent reply other threads:[~2007-04-30 20:06 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-28 19:19 [-mm patch] i386: enable 4k stacks by default Adrian Bunk
2007-04-28 21:18 ` Zan Lynx
2007-04-30 3:58 ` David Chinner
2007-04-30 8:17 ` Alan Cox
2007-04-30 10:26 ` Andi Kleen
2007-04-30 10:48 ` Christoph Hellwig
2007-04-30 12:13 ` Andi Kleen
2007-04-30 17:38 ` William Lee Irwin III
2007-04-30 17:40 ` [1/6] make stack size configurable (was: Re: [-mm patch] i386: enable 4k stacks by default) William Lee Irwin III
2007-04-30 18:10 ` Christoph Hellwig
2007-04-30 18:13 ` William Lee Irwin III
2007-04-30 18:25 ` Adrian Bunk
2007-04-30 18:32 ` William Lee Irwin III
2007-04-30 17:43 ` [2/6] add config option to vmalloc stacks " William Lee Irwin III
2007-04-30 18:11 ` Christoph Hellwig
2007-04-30 18:25 ` Jan Engelhardt
2007-04-30 19:09 ` William Lee Irwin III
2007-04-30 19:15 ` Christoph Hellwig
2007-04-30 19:23 ` Bill Irwin
2007-04-30 22:04 ` Bill Irwin
2007-05-01 22:36 ` Matt Mackall
2007-05-01 22:51 ` Bill Irwin
2007-05-01 23:07 ` Alan Cox
2007-05-01 23:23 ` Bill Irwin
2007-05-01 23:15 ` Matt Mackall
2007-05-01 23:27 ` Bill Irwin
2007-05-04 5:35 ` Joseph Fannin
2007-05-04 7:43 ` Bill Irwin
2007-04-30 17:44 ` [3/6] make IRQ stacks independently configurable " William Lee Irwin III
2007-04-30 18:11 ` Christoph Hellwig
2007-04-30 18:14 ` William Lee Irwin III
2007-04-30 17:45 ` [4/6] go BUG on vmallocspace in __pa() " William Lee Irwin III
2007-04-30 18:52 ` Andi Kleen
2007-04-30 18:58 ` William Lee Irwin III
2007-04-30 19:20 ` Alan Cox
2007-04-30 19:26 ` Bill Irwin
2007-05-02 22:31 ` [4/6] go BUG on vmallocspace in __pa() Jeremy Fitzhardinge
2007-05-02 22:48 ` Bill Irwin
2007-04-30 17:46 ` [5/6] dynamically allocate IRQ stacks (was: Re: [-mm patch] i386: enable 4k stacks by default) William Lee Irwin III
2007-04-30 19:49 ` Zwane Mwaikambo
2007-04-30 20:03 ` Bill Irwin [this message]
2007-04-30 20:07 ` Andi Kleen
2007-04-30 17:47 ` [6/6] arrange for a guard page on cpu 0's IRQ stack " William Lee Irwin III
2007-04-30 18:22 ` [-mm patch] i386: enable 4k stacks by default Jan Engelhardt
2007-04-30 18:35 ` William Lee Irwin III
2007-04-30 18:51 ` Andi Kleen
2007-04-30 8:55 ` Neil Brown
2007-04-30 8:59 ` Christoph Hellwig
2007-04-30 11:30 ` Jens Axboe
2007-04-30 23:24 ` Neil Brown
2007-05-01 8:01 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070430200301.GE26598@holomorphy.com \
--to=bill.irwin@oracle.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=bunk@stusta.de \
--cc=dgc@sgi.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zlynx@acm.org \
--cc=zwane@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox