public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Neil Brown <neilb@suse.de>
Cc: Jeff Layton <jlayton@redhat.com>,
	nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [NFS] [PATCH] RPC: add wrapper for svc_reserve to account for	checksum
Date: Mon, 30 Apr 2007 23:33:10 -0400	[thread overview]
Message-ID: <20070501033310.GB21774@fieldses.org> (raw)
In-Reply-To: <17974.41587.666167.650575@notabene.brown>

On Tue, May 01, 2007 at 12:14:11PM +1000, Neil Brown wrote:
> I don't think this BUG_ON is correct.  If a readdir finds zero entries,
> then will be some trailer information in the 'tail', but page_len will
> be 0.  I think the following patch is correct and could fix that.

Yep.

> Bruce:  does it look OK to you?

It looks sensible, but it's a little late for me--I'll take another look
at it and run some tests tommorow.

--b.

  reply	other threads:[~2007-05-01  3:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-21 13:15 [PATCH] RPC: add wrapper for svc_reserve to account for checksum Jeff Layton
2007-05-01  2:14 ` [NFS] " Neil Brown
2007-05-01  3:33   ` J. Bruce Fields [this message]
2007-05-02  0:34     ` J. Bruce Fields
2007-05-01 17:01   ` Jeff Layton
2007-05-01 17:11     ` Jeff Layton
2007-05-01 21:54       ` Neil Brown
2007-05-02 19:36   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070501033310.GB21774@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=jlayton@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox