Re: [PATCH] Add vDSO for x86-64 with gettimeofday/clock_gettime/getcpu fix

Andi Kleen
2007-04-27T16:36:29Z

On Friday 27 April 2007 17:50:06 Mel Gorman wrote:
> On (27/04/07 09:59), Mel Gorman didst pronounce:
> > On (27/04/07 02:39), Andi Kleen didst pronounce:
> > >
> > >
> > > > That's vdso.lds.S, not vdso.lds. The VDSO_TEXT_OFFSET is still 0x400.
> > > > This is what I should have posted the last time
> > > >
> > > > --- build/arch/x86_64/vdso/voffset.h.orig 2007-04-26 08:43:31.523739878 -0700
> > > > +++ build/arch/x86_64/vdso/voffset.h 2007-04-26 08:43:38.839579356 -0700
> > > > @@ -1 +1 @@
> > > > -#define VDSO_TEXT_OFFSET 0x500
> > > > +#define VDSO_TEXT_OFFSET 0x400
> > >
> > > It's definitely 0x400 here. Is your patch reversed and you want 0x500?
> > >
> >
> > Sorry, that patch is reversed. It's 0x500 it needs to be to work here.
> >
>
> What I should have done in the first place..... Sorry for the noise.

I had already fixed it up.

But now can you test Suresh's latest patch too please?

-Andi