From: Andrew Morton <akpm@linux-foundation.org>
To: Stephen Mollett <molletts@yahoo.com>
Cc: bfennema@falcon.csc.calpoly.edu, linux-kernel@vger.kernel.org,
Jan Kara <jack@ucw.cz>, Dave Hansen <haveblue@us.ibm.com>
Subject: Re: [PATCH 2.6.21] udf: Decrement correct link count in udf_rmdir
Date: Tue, 1 May 2007 14:00:49 -0700 [thread overview]
Message-ID: <20070501140049.04fa2a69.akpm@linux-foundation.org> (raw)
In-Reply-To: <200705011923.14950.molletts@yahoo.com>
On Tue, 1 May 2007 19:23:14 +0100
Stephen Mollett <molletts@yahoo.com> wrote:
> It appears that a minor thinko occurred in udf_rmdir and the (already-cleared)
> link count on the directory that is being removed was being decremented
> instead of the link count on its parent directory. This gives rise to lots of
> kernel messages similar to:
>
> UDF-fs warning (device loop1): udf_rmdir: empty directory has nlink != 2 (8)
>
> when removing directory trees. No other ill effects have been observed but I
> guess it could theoretically result in the link count overflowing on a very
> long-lived, much modified directory.
>
> Signed-off-by: Stephen Mollett <molletts@yahoo.com>
> ---
>
> Patch applies cleanly to latest git snapshot and other recent 2.6 kernels.
>
> Please CC: me as I'm not currently subscribed to linux-kernel.
>
> First attempt at formally submitting a kernel patch - apologies if I've cocked
> something up - please be nice :-)
>
>
> --- linux-2.6.21/fs/udf/namei.c.orig 2007-05-01 18:52:02.000000000 +0100
> +++ linux-2.6.21/fs/udf/namei.c 2007-05-01 18:53:00.000000000 +0100
> @@ -878,7 +878,7 @@ static int udf_rmdir(struct inode * dir,
> inode->i_nlink);
> clear_nlink(inode);
> inode->i_size = 0;
> - inode_dec_link_count(inode);
> + inode_dec_link_count(dir);
> inode->i_ctime = dir->i_ctime = dir->i_mtime = current_fs_time(dir->i_sb);
> mark_inode_dirty(dir);
>
OK, thanks. git-blame says
9a53c3a7 (Dave Hansen 2006-09-30 23:29:03 -0700 881) inode_dec_link_count(inode);
This bug is also fixed in Jan's UDF fixes for 2.6.22, but it looks like I
should make your fix a separate thing, with a 2.6.21.x backport.
prev parent reply other threads:[~2007-05-01 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 18:23 [PATCH 2.6.21] udf: Decrement correct link count in udf_rmdir Stephen Mollett
2007-05-01 21:00 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070501140049.04fa2a69.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bfennema@falcon.csc.calpoly.edu \
--cc=haveblue@us.ibm.com \
--cc=jack@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=molletts@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox