From: Paul Jackson <pj@sgi.com>
To: David Rientjes <rientjes@google.com>
Cc: torvalds@linux-foundation.org, menage@google.com,
clameter@cthulhu.engr.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] cpusets: allow empty {cpus,mems}_allowed to be set for unpopulated cpuset
Date: Tue, 1 May 2007 20:22:01 -0700 [thread overview]
Message-ID: <20070501202201.6903d922.pj@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0705011714490.6376@chino.kir.corp.google.com>
David wrote:
> You currently cannot remove all cpus or mems from cpus_allowed or
> mems_allowed of a cpuset. We now allow both if there are no attached
> tasks.
Why do you need this? It adds a little more code, and changes
semantics a little bit, so I'd think it should have at least a
little bit of justfication.
+ if (!*buf) {
+ cpus_clear(trialcs.cpus_allowed);
Won't the above code fail if someone does:
echo > /dev/cpuset/foobar/mems
Just guessing, but I'd expect buf[] to contain a newline char,
not just a zero length string, at this point.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2007-05-02 3:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 0:16 [patch] cpusets: allow empty {cpus,mems}_allowed to be set for unpopulated cpuset David Rientjes
2007-05-02 3:22 ` Paul Jackson [this message]
2007-05-02 3:36 ` Paul Menage
2007-05-02 7:10 ` Paul Jackson
2007-05-02 7:25 ` Paul Jackson
2007-05-02 8:26 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070501202201.6903d922.pj@sgi.com \
--to=pj@sgi.com \
--cc=clameter@cthulhu.engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox