public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org
Subject: Re: [patch 01/10] compiler: define __attribute_unused__
Date: Tue, 1 May 2007 23:52:37 -0700	[thread overview]
Message-ID: <20070501235237.ba43586a.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0705012336430.22339@chino.kir.corp.google.com>

On Tue, 1 May 2007 23:41:34 -0700 (PDT) David Rientjes <rientjes@google.com> wrote:

> compiler: define __maybe_unused
> 
> Define __maybe_unused to apply to both functions or variables as
> __attribute__((unused)).  This will not emit a compile-time warning when
> a function or variable is declared but unreferenced.
> 
> We eventually want to change the name of __attribute_used__ to __used.
> 
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
>  include/linux/compiler-gcc.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -37,3 +37,4 @@
>  #define  noinline			__attribute__((noinline))
>  #define __attribute_pure__		__attribute__((pure))
>  #define __attribute_const__		__attribute__((__const__))
> +#define __maybe_unused			__attribute__((unused))

Seems sane to me.  We'd need a definition in compiler-intel.h too.  I don't
know if ICC implements __attribute__((unused)) - probably it does.

I guess we can get by without any commentary describing __maybe_unused, but
I think __used would need one - it's pretty obscure.


+@cindex @code{used} attribute.
+@item used
+This attribute, attached to a function, means that code must be emitted
+for the function even if it appears that the function is not referenced.
+This is useful, for example, when the function is referenced only in
+inline assembly.


  reply	other threads:[~2007-05-02  6:52 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-02  4:28 [patch 01/10] compiler: define __attribute_unused__ David Rientjes
2007-05-02  4:28 ` [patch 02/10] i386 pci: type may be unused David Rientjes
2007-05-02  4:28   ` [patch 03/10] sh: dma: use __attribute_unused__ David Rientjes
2007-05-02  4:28     ` [patch 04/10] scsi: fix ambiguous gdthtable definition David Rientjes
2007-05-02  4:28       ` [patch 05/10] frv: gdb: use __attribute_unused__ David Rientjes
2007-05-02  4:28         ` [patch 06/10] i386: voyager: " David Rientjes
2007-05-02  4:28           ` [patch 07/10] mips: excite: " David Rientjes
2007-05-02  4:28             ` [patch 08/10] mips: tlbex: " David Rientjes
2007-05-02  4:28               ` [patch 09/10] powerpc: ps3: " David Rientjes
2007-05-02  4:28                 ` [patch 10/10] i386 mmzone: " David Rientjes
2007-05-02 15:42                 ` [patch 09/10] powerpc: ps3: " Geoff Levand
2007-05-03 17:23               ` [patch 08/10] mips: tlbex: " Ralf Baechle
2007-05-03 17:23             ` [patch 07/10] mips: excite: " Ralf Baechle
2007-05-07  1:28     ` [patch 03/10] sh: dma: " Paul Mundt
2007-05-02 10:35   ` [patch 02/10] i386 pci: type may be unused Andi Kleen
2007-05-02 17:05     ` David Rientjes
2007-05-02  5:17 ` [patch 01/10] compiler: define __attribute_unused__ Alexey Dobriyan
2007-05-02  5:53   ` David Rientjes
2007-05-02  6:08     ` Andrew Morton
2007-05-02  6:46       ` Nick Piggin
2007-05-02  6:33     ` WANG Cong
2007-05-02  7:02   ` Robert P. J. Day
2007-05-02  7:17     ` David Rientjes
2007-05-02  7:47       ` Robert P. J. Day
2007-05-02  5:40 ` Rusty Russell
2007-05-02  6:06   ` David Rientjes
2007-05-02  6:25     ` David Rientjes
2007-05-02  6:29     ` Rusty Russell
2007-05-02  6:41       ` David Rientjes
2007-05-02  6:52         ` Andrew Morton [this message]
2007-05-02  7:04         ` Rusty Russell
2007-05-02  7:22           ` David Rientjes
2007-05-02  7:51             ` Rusty Russell
2007-05-02 14:55             ` Adrian Bunk
2007-05-02 15:05               ` Adrian Bunk
2007-05-02 17:16                 ` David Rientjes
2007-05-03 17:51                   ` Adrian Bunk
2007-05-03 18:56                     ` David Rientjes
2007-05-03 19:05                       ` Adrian Bunk
2007-05-03 19:24                         ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070501235237.ba43586a.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox