Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

Dave Jones
2007-04-26T04:25:42Z

On Wed, Apr 25, 2007 at 08:02:07PM -0700, Andrew Morton wrote:
> On Wed, 25 Apr 2007 19:38:23 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > > In fact, I should probably munge it together with a similar thing
> > > I wrote at http://www.codemonkey.org.uk/projects/findbugs/
> > > (Warning: scary regexps)
> > I'll be glad to help maintain such animals if wanted.
>
> wanted ;)
>
> At least, it would be interesting to investigate the usefulness. I suspect
> it will prove to be very useful for the little things.

Yeah, the original script tried to do things like spinlock balancing checks,
(badly). This was long before had sparse, and it was partly a "lets learn some perl"
experience for myself. I'll toss that idea out now that we have better tools
for that, and keep it to simple checks.

> Heck, someone could subscribe a robot to all the mailing lists which sends
> nastygrams straight back at people who submit broken patches. We already
> need that for tab-replaced and word-wrapped patches. (ok, we have it -
> it's called akpm, but being robotic wearies one)

Ok, I've got a few different flavours of that script. I'll roll them
all into one tomorrow and throw out some of the noisy silly ones
(I don't think warning about strcpy->strncpy is really worthwhile for eg).

Additional regexps gratefully recieved.

Dave

--