Re: checkpatch, a patch checking script.

Randy Dunlap
2007-04-30T00:56:54Z

On Fri, 27 Apr 2007 22:18:03 -0700 Andrew Morton wrote:

> On Fri, 27 Apr 2007 23:08:05 -0400 Dave Jones <davej@redhat.com> wrote:
>
> > You can find the script at http://www.codemonkey.org.uk/projects/checkpatch/
>
> hm.
>
...

> box:/usr/src/25> ~/checkpatch.pl patches/git-powerpc.patch
> Checking patches/git-powerpc.patch: signoffs = 427
> kmalloc return shouldn't be cast.
> 10969:+ char *out = (char*)kmalloc(count + 1, GFP_KERNEL);
>
> Use 'inline' instead of '__inline__'26644:+static __inline__ void atomic_scrub(void *va, u32 size)

Fixed missing \n.

...

> A good start, thanks. The BUG_ON() thing might be unpopular, but I think it's
> for the best. It should skip BUILD_BUG_ON though.

BUILD_BUG_ON is now skipped (in my script, not sent to DaveJ yet).

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***