From: Andrew Morton <akpm@linux-foundation.org>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: thomas@winischhofer.net, LKML <linux-kernel@vger.kernel.org>,
Wang Ya-gang <lazy_linux@126.com>,
Chen Li-jun <cljun@xiyou.edu.cn>
Subject: Re: [Patch][SIS USB2VGA] Warning fix
Date: Wed, 2 May 2007 22:48:41 -0700 [thread overview]
Message-ID: <20070502224841.030091cd.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070503053429.GA3166@localhost.localdomain>
On Thu, 3 May 2007 13:34:29 +0800 WANG Cong <xiyou.wangcong@gmail.com> wrote:
>
> Fix this warning:
> drivers/usb/misc/sisusbvga/sisusb_con.c:1436: warning: initialization from incompatible pointer type
>
>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
> ---
>
> Compiling test past.;)
>
Thanks.
> --- linux-2.6.21-rc7-mm2/drivers/usb/misc/sisusbvga/sisusb_con.c.orig 2007-05-03 02:51:06.000000000 +0800
> +++ linux-2.6.21-rc7-mm2/drivers/usb/misc/sisusbvga/sisusb_con.c 2007-05-03 02:57:08.000000000 +0800
> @@ -321,9 +321,10 @@ sisusbcon_deinit(struct vc_data *c)
> /* interface routine */
> static u8
> sisusbcon_build_attr(struct vc_data *c, u8 color, u8 intensity,
> - u8 blink, u8 underline, u8 reverse)
> + u8 blink, u8 underline, u8 reverse, u8 unused)
> {
> u8 attr = color;
> + (void) unused;
This part isn't needed and we don't usually do it - the compiler will not warn
about the unused arg.
prev parent reply other threads:[~2007-05-03 5:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 5:34 [Patch][SIS USB2VGA] Warning fix WANG Cong
2007-05-03 5:48 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070502224841.030091cd.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cljun@xiyou.edu.cn \
--cc=lazy_linux@126.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@winischhofer.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox